All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Chen Gang <762976180@qq.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Fwd: [PATCH] c6x: asm: pgtable: Define dummy pgprot_writecombine for !MMU
Date: Tue, 03 Mar 2015 07:15:15 +0800	[thread overview]
Message-ID: <54F4EF03.5060403@sunrus.com.cn> (raw)
In-Reply-To: <54F4ECF1.6060709@qq.com>




-------- Forwarded Message --------
Subject: [PATCH] c6x: asm: pgtable: Define dummy pgprot_writecombine for !MMU
Date: Tue, 03 Mar 2015 07:06:25 +0800
From: Chen Gang <762976180@qq.com>
To: msalter@redhat.com, a-jacquiot@ti.com
CC: kirill.shutemov@linux.intel.com, Andrew Morton <akpm@linux-foundation.org>, linux-c6x-dev@linux-c6x.org <linux-c6x-dev@linux-c6x.org>, linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>

When !MMU, asm-generic will not define default pgprot_writecombine, so
c6x needs to define it by itself. The related error:

    CC [M]  fs/pstore/ram_core.o
  fs/pstore/ram_core.c: In function 'persistent_ram_vmap':
  fs/pstore/ram_core.c:399:10: error: implicit declaration of function 'pgprot_writecombine' [-Werror=implicit-function-declaration]
     prot = pgprot_writecombine(PAGE_KERNEL);
            ^
  fs/pstore/ram_core.c:399:8: error: incompatible types when assigning to type 'pgprot_t {aka struct <anonymous>}' from type 'int'
     prot = pgprot_writecombine(PAGE_KERNEL);
          ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/c6x/include/asm/pgtable.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/c6x/include/asm/pgtable.h b/arch/c6x/include/asm/pgtable.h
index 78d4483..ec4db6d 100644
--- a/arch/c6x/include/asm/pgtable.h
+++ b/arch/c6x/include/asm/pgtable.h
@@ -67,6 +67,11 @@ extern unsigned long empty_zero_page;
  */
 #define pgtable_cache_init()   do { } while (0)
 
+/*
+ * c6x is !MMU, so define the simpliest implementation
+ */
+#define pgprot_writecombine pgprot_noncached
+
 #include <asm-generic/pgtable.h>
 
 #endif /* _ASM_C6X_PGTABLE_H */
-- 
1.9.3



           reply	other threads:[~2015-03-02 23:08 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <54F4ECF1.6060709@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F4EF03.5060403@sunrus.com.cn \
    --to=gang.chen@sunrus.com.cn \
    --cc=762976180@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.