From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" Date: Tue, 03 Mar 2015 11:42:14 +1100 Message-ID: <54F50366.6080105@ozlabs.ru> References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> <54F468D5.2060407@suse.de> <54F46AF7.60209@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-stable@nongnu.org, Paolo Bonzini , qemu-ppc , kvm To: Alexander Graf , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Return-path: Received: from mail-pd0-f182.google.com ([209.85.192.182]:45731 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754990AbbCCAmX (ORCPT ); Mon, 2 Mar 2015 19:42:23 -0500 Received: by pdjz10 with SMTP id z10so43699433pdj.12 for ; Mon, 02 Mar 2015 16:42:22 -0800 (PST) In-Reply-To: <54F46AF7.60209@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 03/03/2015 12:51 AM, Alexander Graf wrote: > > > On 02.03.15 14:42, Andreas F=C3=A4rber wrote: >> Am 02.03.2015 um 14:37 schrieb Alexander Graf: >>> On 01.03.15 01:31, Andreas F=C3=A4rber wrote: >>>> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to av= oid >>>> double-registration of types: >>>> >>>> Registering `POWER5+-powerpc64-cpu' which already exists >>>> >>>> Taking the textual description of a CPU type as part of a new type= name >>>> is plain wrong, and so is unconditionally registering a new type h= ere. >>>> >>>> Cc: Alexey Kardashevskiy >>>> Cc: qemu-stable@nongnu.org >>>> Signed-off-by: Andreas F=C3=A4rber >>> >>> Doesn't this break p8 support? >> >> Maybe, but p5 support was in longer and this is definitely a regress= ion >> and really really wrong. If you know a way to fix it without handing= it >> back to the IBM guys for more thought, feel free to give it a shot. > > I honestly don't fully remember what this was about. Wasn't this our > special KVM class that we use to create a compatible cpu type on the = fly? > > Alexey, please take a look at it. I sent a note yesterday :-/ Here it is again: With this revert, running qemu with HV KVM and -cpu POWER7 fails on rea= l=20 POWER7 machine as my machine has pvr 003f 0201 and POWER7 is an alias o= f=20 POWER7_v2.3 (pvr 003f 0203); and this is what I tried to fix at the fir= st=20 place. QEMU looks at classes first, and if not found - at aliases, so t= his=20 worked. I would rename "POWER5+" to "POWER5+_0.0" and make "POWER5+" an alias f= or=20 POWER5+_v2.1 (or POWER5+_0.0). --=20 Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSauu-0000fh-K1 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 19:42:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSaum-0005zH-4K for qemu-devel@nongnu.org; Mon, 02 Mar 2015 19:42:32 -0500 Received: from mail-pd0-f182.google.com ([209.85.192.182]:46366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSaul-0005ym-T9 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 19:42:24 -0500 Received: by pdjy10 with SMTP id y10so43674241pdj.13 for ; Mon, 02 Mar 2015 16:42:22 -0800 (PST) Message-ID: <54F50366.6080105@ozlabs.ru> Date: Tue, 03 Mar 2015 11:42:14 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> <54F468D5.2060407@suse.de> <54F46AF7.60209@suse.de> In-Reply-To: <54F46AF7.60209@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc , qemu-stable@nongnu.org, kvm On 03/03/2015 12:51 AM, Alexander Graf wrote: > > > On 02.03.15 14:42, Andreas Färber wrote: >> Am 02.03.2015 um 14:37 schrieb Alexander Graf: >>> On 01.03.15 01:31, Andreas Färber wrote: >>>> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avoid >>>> double-registration of types: >>>> >>>> Registering `POWER5+-powerpc64-cpu' which already exists >>>> >>>> Taking the textual description of a CPU type as part of a new type name >>>> is plain wrong, and so is unconditionally registering a new type here. >>>> >>>> Cc: Alexey Kardashevskiy >>>> Cc: qemu-stable@nongnu.org >>>> Signed-off-by: Andreas Färber >>> >>> Doesn't this break p8 support? >> >> Maybe, but p5 support was in longer and this is definitely a regression >> and really really wrong. If you know a way to fix it without handing it >> back to the IBM guys for more thought, feel free to give it a shot. > > I honestly don't fully remember what this was about. Wasn't this our > special KVM class that we use to create a compatible cpu type on the fly? > > Alexey, please take a look at it. I sent a note yesterday :-/ Here it is again: With this revert, running qemu with HV KVM and -cpu POWER7 fails on real POWER7 machine as my machine has pvr 003f 0201 and POWER7 is an alias of POWER7_v2.3 (pvr 003f 0203); and this is what I tried to fix at the first place. QEMU looks at classes first, and if not found - at aliases, so this worked. I would rename "POWER5+" to "POWER5+_0.0" and make "POWER5+" an alias for POWER5+_v2.1 (or POWER5+_0.0). -- Alexey