From: Tariq Saeed <tariq.x.saeed@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] question related to [PATCH 1/1] BUG_ON(lockres->l_level != DLM_LOCK_EX ...
Date: Mon, 02 Mar 2015 17:30:51 -0800 [thread overview]
Message-ID: <54F50ECB.20800@oracle.com> (raw)
In-Reply-To: <1425333797-26082-1-git-send-email-tariq.x.saeed@oracle.com>
> Ocfs2-devel] [PATCH 1/1] BUG_ON(lockres->l_level != DLM_LOCK_EX &&
> !checkpointed) tripped in ocfs2_ci_checkpointed
As I was working on this patch, I noticed that the changes in
ocfs2_setattr are done in more than
one transaction --> in case of crash somewhere in this func, say after
doing the first trans,
the inode could be in a state where only some of the changes have
been applied (after log replay).
Checking ext3_ocfs2, from where this code was ported, I found the same
issue there as well.
Do you have any comments?
Thanks
-Tariq Saeed
PS I realize that doing everything in ocfs2_setattr in a single
transaction is a major surgery as
the functions called down the path for xattr start their own
transactions with different credits.
next prev parent reply other threads:[~2015-03-03 1:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 22:03 [Ocfs2-devel] [PATCH 1/1] BUG_ON(lockres->l_level != DLM_LOCK_EX && !checkpointed) tripped in ocfs2_ci_checkpointed Tariq Saeed
2015-03-03 1:30 ` Tariq Saeed [this message]
2015-03-05 0:13 ` [Ocfs2-devel] question related to [PATCH 1/1] BUG_ON(lockres->l_level != DLM_LOCK_EX Mark Fasheh
2015-03-04 23:57 ` [Ocfs2-devel] [PATCH 1/1] BUG_ON(lockres->l_level != DLM_LOCK_EX && !checkpointed) tripped in ocfs2_ci_checkpointed Mark Fasheh
2015-03-05 19:33 ` Tariq Saeed
2015-03-05 21:34 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F50ECB.20800@oracle.com \
--to=tariq.x.saeed@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.