From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v4 13/30] PCI: Introduce new scan function pci_scan_root_bridge() Date: Tue, 3 Mar 2015 16:12:07 +0800 Message-ID: <54F56CD7.8080906@huawei.com> References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-14-git-send-email-wangyijing@huawei.com> <20150303025222.GG11978@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150303025222.GG11978@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven On 2015/3/3 10:52, Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:12:07PM +0800, Yijing Wang wrote: >> Introduce new scan function pci_scan_root_bridge() to >> support host bridge drivers that need to provide platform >> own pci_host_bridge_ops. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/probe.c | 21 +++++++++++++++++++++ >> include/linux/pci.h | 3 +++ >> 2 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 8cec6ab..b5f9ca4 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -2063,6 +2063,27 @@ static struct pci_bus *__pci_scan_root_bus( >> return b; >> } >> >> +struct pci_host_bridge *pci_scan_root_bridge(struct device *parent, >> + u32 db, struct pci_ops *ops, void *sysdata, >> + struct list_head *resources, struct pci_host_bridge_ops *phb_ops) > > I prefer "host bridge" over "root bridge" because that's the terminology > used by the PCI specs. OK, I will use "host bridge" instead of "root bridge". > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Tue, 03 Mar 2015 08:12:07 +0000 Subject: Re: [PATCH v4 13/30] PCI: Introduce new scan function pci_scan_root_bridge() Message-Id: <54F56CD7.8080906@huawei.com> List-Id: References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-14-git-send-email-wangyijing@huawei.com> <20150303025222.GG11978@google.com> In-Reply-To: <20150303025222.GG11978@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@vger.kernel.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven On 2015/3/3 10:52, Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:12:07PM +0800, Yijing Wang wrote: >> Introduce new scan function pci_scan_root_bridge() to >> support host bridge drivers that need to provide platform >> own pci_host_bridge_ops. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/probe.c | 21 +++++++++++++++++++++ >> include/linux/pci.h | 3 +++ >> 2 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 8cec6ab..b5f9ca4 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -2063,6 +2063,27 @@ static struct pci_bus *__pci_scan_root_bus( >> return b; >> } >> >> +struct pci_host_bridge *pci_scan_root_bridge(struct device *parent, >> + u32 db, struct pci_ops *ops, void *sysdata, >> + struct list_head *resources, struct pci_host_bridge_ops *phb_ops) > > I prefer "host bridge" over "root bridge" because that's the terminology > used by the PCI specs. OK, I will use "host bridge" instead of "root bridge". > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com ([119.145.14.64]:31846 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbbCCINA (ORCPT ); Tue, 3 Mar 2015 03:13:00 -0500 Message-ID: <54F56CD7.8080906@huawei.com> Date: Tue, 3 Mar 2015 16:12:07 +0800 From: Yijing Wang MIME-Version: 1.0 To: Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v4 13/30] PCI: Introduce new scan function pci_scan_root_bridge() References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-14-git-send-email-wangyijing@huawei.com> <20150303025222.GG11978@google.com> In-Reply-To: <20150303025222.GG11978@google.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-pci-owner@vger.kernel.org List-ID: On 2015/3/3 10:52, Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:12:07PM +0800, Yijing Wang wrote: >> Introduce new scan function pci_scan_root_bridge() to >> support host bridge drivers that need to provide platform >> own pci_host_bridge_ops. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/probe.c | 21 +++++++++++++++++++++ >> include/linux/pci.h | 3 +++ >> 2 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 8cec6ab..b5f9ca4 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -2063,6 +2063,27 @@ static struct pci_bus *__pci_scan_root_bus( >> return b; >> } >> >> +struct pci_host_bridge *pci_scan_root_bridge(struct device *parent, >> + u32 db, struct pci_ops *ops, void *sysdata, >> + struct list_head *resources, struct pci_host_bridge_ops *phb_ops) > > I prefer "host bridge" over "root bridge" because that's the terminology > used by the PCI specs. OK, I will use "host bridge" instead of "root bridge". > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Tue, 3 Mar 2015 16:12:07 +0800 Subject: [PATCH v4 13/30] PCI: Introduce new scan function pci_scan_root_bridge() In-Reply-To: <20150303025222.GG11978@google.com> References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-14-git-send-email-wangyijing@huawei.com> <20150303025222.GG11978@google.com> Message-ID: <54F56CD7.8080906@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/3/3 10:52, Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:12:07PM +0800, Yijing Wang wrote: >> Introduce new scan function pci_scan_root_bridge() to >> support host bridge drivers that need to provide platform >> own pci_host_bridge_ops. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/probe.c | 21 +++++++++++++++++++++ >> include/linux/pci.h | 3 +++ >> 2 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 8cec6ab..b5f9ca4 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -2063,6 +2063,27 @@ static struct pci_bus *__pci_scan_root_bus( >> return b; >> } >> >> +struct pci_host_bridge *pci_scan_root_bridge(struct device *parent, >> + u32 db, struct pci_ops *ops, void *sysdata, >> + struct list_head *resources, struct pci_host_bridge_ops *phb_ops) > > I prefer "host bridge" over "root bridge" because that's the terminology > used by the PCI specs. OK, I will use "host bridge" instead of "root bridge". > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090AbbCCINE (ORCPT ); Tue, 3 Mar 2015 03:13:04 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:31846 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbbCCINA (ORCPT ); Tue, 3 Mar 2015 03:13:00 -0500 Message-ID: <54F56CD7.8080906@huawei.com> Date: Tue, 3 Mar 2015 16:12:07 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v4 13/30] PCI: Introduce new scan function pci_scan_root_bridge() References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-14-git-send-email-wangyijing@huawei.com> <20150303025222.GG11978@google.com> In-Reply-To: <20150303025222.GG11978@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/3 10:52, Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:12:07PM +0800, Yijing Wang wrote: >> Introduce new scan function pci_scan_root_bridge() to >> support host bridge drivers that need to provide platform >> own pci_host_bridge_ops. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/probe.c | 21 +++++++++++++++++++++ >> include/linux/pci.h | 3 +++ >> 2 files changed, 24 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 8cec6ab..b5f9ca4 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -2063,6 +2063,27 @@ static struct pci_bus *__pci_scan_root_bus( >> return b; >> } >> >> +struct pci_host_bridge *pci_scan_root_bridge(struct device *parent, >> + u32 db, struct pci_ops *ops, void *sysdata, >> + struct list_head *resources, struct pci_host_bridge_ops *phb_ops) > > I prefer "host bridge" over "root bridge" because that's the terminology > used by the PCI specs. OK, I will use "host bridge" instead of "root bridge". > > . > -- Thanks! Yijing