All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Liquid.Acid@gmx.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain
Date: Tue, 03 Mar 2015 09:12:20 +0100	[thread overview]
Message-ID: <54F56CE4.8000704@collabora.co.uk> (raw)
In-Reply-To: <54D4A534.8060004@collabora.co.uk>

Hello Kukjin,

On 02/06/2015 12:27 PM, Javier Martinez Canillas wrote:
> Hello Andrzej,
> 
> On 02/06/2015 11:55 AM, Andrzej Hajda wrote:
>> FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER),
>> therefore their clocks should be enabled during power domain switch.
>> 
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>> Hi,
>> 
>> This is 2nd version of the patch. After decrypting manual and discussion
>> with Marek I guess this set of clocks is more apropriate - async-bridges
>> are present in MIXER and FIMD, so their clocks should be enabled.
>>
> 
> I just tested this version on my Exynos5420 Peach Pit and the power domain
> failed error does not happen anymore even after enabling and disabling the
> HDMI display several times.
> 
> Thanks a lot for fixing this since the dependency was not clear to me from
> reading the manual.
> 
>> The 1st version worked for me due to fact I have forgot to remove
>> clk_ignore_unused kernel boot option during tests ;)
>>
> 
> Yes, that has bitten me too many times as well :)
> 
>> Regards
>> Andrzej
>> ---
> 
> Best regards,
> Javier
> 

Could you please pick this patch and patches 1/2 and 2/3 from the series [0]?

These are needed to fix DISP1 power domain issues and HDMI on Exynos542x.

Thanks a lot and best regards,
Javier

[0]: https://lkml.org/lkml/2015/2/5/265

  reply	other threads:[~2015-03-03  8:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 12:35 [RFC PATCH 0/3] Fix power domains handling on exynos542x Andrzej Hajda
2015-02-05 12:35 ` Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 1/3] arm/exynos: add asynchronous bridge clock bindings Andrzej Hajda
2015-02-05 12:35   ` Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks Andrzej Hajda
2015-02-05 12:35   ` Andrzej Hajda
2015-03-12 13:05   ` Sylwester Nawrocki
2015-03-12 13:05     ` Sylwester Nawrocki
2015-02-05 12:35 ` [RFC PATCH 3/3] ARM: dts: exynos5420: add async-bridge clock to disp1 power domain Andrzej Hajda
2015-02-05 12:35   ` Andrzej Hajda
     [not found] ` <1423139739-19881-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-05 14:45   ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Javier Martinez Canillas
2015-02-05 14:45     ` Javier Martinez Canillas
2015-02-06  5:27     ` Joonyoung Shim
2015-02-06  5:27       ` Joonyoung Shim
2015-02-06  9:18       ` Javier Martinez Canillas
2015-02-06 10:55         ` [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain Andrzej Hajda
     [not found]           ` <1423220154-5333-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-06 11:27             ` Javier Martinez Canillas
2015-02-06 11:27               ` Javier Martinez Canillas
2015-03-03  8:12               ` Javier Martinez Canillas [this message]
2015-03-12 13:00           ` Sylwester Nawrocki
2015-03-12 13:00             ` Sylwester Nawrocki
2015-03-10  9:48     ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F56CE4.8000704@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=Liquid.Acid@gmx.net \
    --cc=a.hajda@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.