From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] perl: needs host-bison
Date: Tue, 03 Mar 2015 07:54:42 -0300 [thread overview]
Message-ID: <54F592F2.80405@zacarias.com.ar> (raw)
In-Reply-To: <20150303114820.32b71d7b@free-electrons.com>
On 03/03/2015 07:48 AM, Thomas Petazzoni wrote:
> Dear Gustavo Zacarias,
>
> On Tue, 3 Mar 2015 07:31:03 -0300, Gustavo Zacarias wrote:
>
>> define PERL_BUILD_CMDS
>> - $(MAKE1) -C $(@D) all
>> + PATH=$(BR_PATH) $(MAKE1) -C $(@D) all
>
> Use $(TARGET_MAKE_ENV) instead.
>
>> define HOST_PERL_BUILD_CMDS
>> - $(MAKE) -C $(@D)
>> + PATH=$(BR_PATH) $(MAKE) -C $(@D)
>
> and $(HOST_MAKE_ENV).
For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's
not and it'll need extra testing to see that perl's build system doesn't
fluke with the extras.
So splitting between BR_PATH and TARGET_MAKE_ENV is possible but not
visually consistent.
Which begs the question: why do other packages use BR_PATH in the same
way as well? (without using *_MAKE_ENV)
Regards.
next prev parent reply other threads:[~2015-03-03 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:31 [Buildroot] [PATCH] perl: needs host-bison Gustavo Zacarias
2015-03-03 10:48 ` Thomas Petazzoni
2015-03-03 10:54 ` Gustavo Zacarias [this message]
2015-03-03 10:59 ` Thomas Petazzoni
2015-03-03 11:03 ` Gustavo Zacarias
2015-03-04 18:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F592F2.80405@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.