All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Tue, 03 Mar 2015 12:06:40 +0100	[thread overview]
Message-ID: <54F595C0.5060004@redhat.com> (raw)
In-Reply-To: <8761ai73j1.fsf@linaro.org>



On 03/03/2015 11:56, Alex Bennée wrote:
> > > This adds the saving and restore of the current Multi-Processing state
> > > of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of
> > > potential states for x86 we only use two for ARM. Either the process is
> > > running or not.
> >
> > By this you mean "is the CPU in the PSCI powered down state or not",
> > right?
> 
> From the vcpu's perspective it is either running or not. However it is
> the same mechanism that is used when PSCI_0_2_FN_CPU_OFF is passed the
> VM, internally setting vcpu->arch.paused.

I suggest that you define a new MP_STATE constant for this.  HALTED in
x86 and s390 is the state an ARM processor enters when you execute wfi.
 Right now this is not migrated on ARM if I remember correctly, but
perhaps you'll want to add it in the future.

Paolo
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Tue, 03 Mar 2015 12:06:40 +0100	[thread overview]
Message-ID: <54F595C0.5060004@redhat.com> (raw)
In-Reply-To: <8761ai73j1.fsf@linaro.org>



On 03/03/2015 11:56, Alex Benn?e wrote:
> > > This adds the saving and restore of the current Multi-Processing state
> > > of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of
> > > potential states for x86 we only use two for ARM. Either the process is
> > > running or not.
> >
> > By this you mean "is the CPU in the PSCI powered down state or not",
> > right?
> 
> From the vcpu's perspective it is either running or not. However it is
> the same mechanism that is used when PSCI_0_2_FN_CPU_OFF is passed the
> VM, internally setting vcpu->arch.paused.

I suggest that you define a new MP_STATE constant for this.  HALTED in
x86 and s390 is the state an ARM processor enters when you execute wfi.
 Right now this is not migrated on ARM if I remember correctly, but
perhaps you'll want to add it in the future.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Qemu-devel] [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Tue, 03 Mar 2015 12:06:40 +0100	[thread overview]
Message-ID: <54F595C0.5060004@redhat.com> (raw)
In-Reply-To: <8761ai73j1.fsf@linaro.org>



On 03/03/2015 11:56, Alex Bennée wrote:
> > > This adds the saving and restore of the current Multi-Processing state
> > > of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of
> > > potential states for x86 we only use two for ARM. Either the process is
> > > running or not.
> >
> > By this you mean "is the CPU in the PSCI powered down state or not",
> > right?
> 
> From the vcpu's perspective it is either running or not. However it is
> the same mechanism that is used when PSCI_0_2_FN_CPU_OFF is passed the
> VM, internally setting vcpu->arch.paused.

I suggest that you define a new MP_STATE constant for this.  HALTED in
x86 and s390 is the state an ARM processor enters when you execute wfi.
 Right now this is not migrated on ARM if I remember correctly, but
perhaps you'll want to add it in the future.

Paolo

  reply	other threads:[~2015-03-03 11:00 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 16:02 [PATCH 0/6] QEMU ARM64 Migration Fixes Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 1/6] target-arm: kvm: save/restore mp state Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 23:36   ` Peter Maydell
2015-02-25 23:36     ` [Qemu-devel] " Peter Maydell
2015-02-25 23:36     ` Peter Maydell
2015-03-03 10:56     ` Alex Bennée
2015-03-03 10:56       ` [Qemu-devel] " Alex Bennée
2015-03-03 10:56       ` Alex Bennée
2015-03-03 11:06       ` Paolo Bonzini [this message]
2015-03-03 11:06         ` [Qemu-devel] " Paolo Bonzini
2015-03-03 11:06         ` Paolo Bonzini
2015-03-03 11:51         ` Peter Maydell
2015-03-03 11:51           ` [Qemu-devel] " Peter Maydell
2015-03-03 11:51           ` Peter Maydell
2015-03-03 16:30           ` Alex Bennée
2015-03-03 16:30             ` [Qemu-devel] " Alex Bennée
2015-03-03 16:30             ` Alex Bennée
2015-03-03 17:10             ` Paolo Bonzini
2015-03-03 17:10               ` [Qemu-devel] " Paolo Bonzini
2015-03-03 17:10               ` Paolo Bonzini
2015-02-26 12:57   ` Paolo Bonzini
2015-02-26 12:57     ` [Qemu-devel] " Paolo Bonzini
2015-02-26 12:57     ` Paolo Bonzini
2015-02-25 16:02 ` [PATCH 2/6] arm_gic_kvm.c: restore config before pending IRQs Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-02 22:14   ` Christoffer Dall
2015-03-02 22:14     ` [Qemu-devel] " Christoffer Dall
2015-03-02 22:14     ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 3/6] hw/char/pl011: don't keep setting the IRQ if nothing changed Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 4/6] target-arm/kvm64.c: sync FP register state Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR registers Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-02 17:22   ` Christoffer Dall
2015-03-02 17:22     ` [Qemu-devel] " Christoffer Dall
2015-03-02 17:22     ` Christoffer Dall
2015-03-03 11:28     ` Alex Bennée
2015-03-03 11:28       ` [Qemu-devel] " Alex Bennée
2015-03-03 11:28       ` Alex Bennée
2015-03-09 12:56       ` Christoffer Dall
2015-03-09 12:56         ` [Qemu-devel] " Christoffer Dall
2015-03-09 12:56         ` Christoffer Dall
2015-03-09 13:31         ` Peter Maydell
2015-03-09 13:31           ` [Qemu-devel] " Peter Maydell
2015-03-09 13:31           ` Peter Maydell
2015-03-09 16:25           ` Alex Bennée
2015-03-09 16:25             ` [Qemu-devel] " Alex Bennée
2015-03-09 16:25             ` Alex Bennée
2015-03-09 16:25             ` Alex Bennée
2015-03-09 19:31           ` Christoffer Dall
2015-03-09 19:31             ` [Qemu-devel] " Christoffer Dall
2015-03-09 19:31             ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 6/6] target-arm/cpu.h: document why env->spsr exists Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-11 15:39   ` [Qemu-devel] " Greg Bellows
2015-03-11 15:39     ` Greg Bellows
2015-03-11 15:39     ` Greg Bellows
2015-03-11 15:47   ` Peter Maydell
2015-03-11 15:47     ` [Qemu-devel] " Peter Maydell
2015-03-11 15:47     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F595C0.5060004@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.