From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 03 Mar 2015 12:16:57 +0100 Subject: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers In-Reply-To: <20150303085204.GA4911@lukather> References: <1422265856-27631-1-git-send-email-maxime.ripard@free-electrons.com> <1422265856-27631-6-git-send-email-maxime.ripard@free-electrons.com> <54C62368.7050600@linaro.org> <20150126143541.GG31568@lukather> <20150303085204.GA4911@lukather> Message-ID: <54F59829.2070205@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/03/2015 09:52 AM, Maxime Ripard wrote: > On Mon, Jan 26, 2015 at 03:35:41PM +0100, Maxime Ripard wrote: >>>> +static int sun5i_rate_cb_clksrc(struct notifier_block *nb, >>>> + unsigned long event, void *data) >>>> +{ >>>> + struct clk_notifier_data *ndata = data; >>>> + struct sun5i_timer *timer = to_sun5i_timer(nb); >>>> + struct sun5i_timer_clksrc *cs = container_of(timer, >>>> + struct sun5i_timer_clksrc, timer); >>>> + >>>> + switch (event) { >>>> + case PRE_RATE_CHANGE: >>>> + clocksource_unregister(&cs->clksrc); >>>> + break; >>>> + >>>> + case POST_RATE_CHANGE: >>>> + clocksource_register_hz(&cs->clksrc, ndata->new_rate); >>>> + break; >>> >>> Why clocksource_unregister couldn't be in the POST_RATE_CHANGE ? >> >> Wouldn't that leave a (small, I agree) window where the timer would >> run at a rate different to the one it has been registered with? > > Ping? Hi Maxime, except I missed something, there were a couple of comments and I was waiting a V3. -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756115AbbCCLRD (ORCPT ); Tue, 3 Mar 2015 06:17:03 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:46155 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754952AbbCCLRB (ORCPT ); Tue, 3 Mar 2015 06:17:01 -0500 Message-ID: <54F59829.2070205@linaro.org> Date: Tue, 03 Mar 2015 12:16:57 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Maxime Ripard CC: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers References: <1422265856-27631-1-git-send-email-maxime.ripard@free-electrons.com> <1422265856-27631-6-git-send-email-maxime.ripard@free-electrons.com> <54C62368.7050600@linaro.org> <20150126143541.GG31568@lukather> <20150303085204.GA4911@lukather> In-Reply-To: <20150303085204.GA4911@lukather> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2015 09:52 AM, Maxime Ripard wrote: > On Mon, Jan 26, 2015 at 03:35:41PM +0100, Maxime Ripard wrote: >>>> +static int sun5i_rate_cb_clksrc(struct notifier_block *nb, >>>> + unsigned long event, void *data) >>>> +{ >>>> + struct clk_notifier_data *ndata = data; >>>> + struct sun5i_timer *timer = to_sun5i_timer(nb); >>>> + struct sun5i_timer_clksrc *cs = container_of(timer, >>>> + struct sun5i_timer_clksrc, timer); >>>> + >>>> + switch (event) { >>>> + case PRE_RATE_CHANGE: >>>> + clocksource_unregister(&cs->clksrc); >>>> + break; >>>> + >>>> + case POST_RATE_CHANGE: >>>> + clocksource_register_hz(&cs->clksrc, ndata->new_rate); >>>> + break; >>> >>> Why clocksource_unregister couldn't be in the POST_RATE_CHANGE ? >> >> Wouldn't that leave a (small, I agree) window where the timer would >> run at a rate different to the one it has been registered with? > > Ping? Hi Maxime, except I missed something, there were a couple of comments and I was waiting a V3. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog