From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES Date: Tue, 03 Mar 2015 11:51:25 +0000 Message-ID: <54F5A03D.8010302@linaro.org> References: <1424264213-30614-1-git-send-email-vijay.kilari@gmail.com> <54E48DAB.5030307@linaro.org> <1424770282.27930.259.camel@citrix.com> <54EC4699.8050905@linaro.org> <1424773562.27930.301.camel@citrix.com> <54EC75C7.7040209@linaro.org> <1425378478.24959.71.camel@citrix.com> <54F59853.4070109@linaro.org> <1425383276.24959.119.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425383276.24959.119.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Vijay Kilari , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 03/03/2015 11:47, Ian Campbell wrote: >> I'm not sure to follow here. Do you think MAP_SMALL_PAGES should be >> defined as WRITE_ALLOC? > > Sorry I just meant that: > +#define PAGE_HYPERVISOR_WC ((DEV_WC) | PTE_PRESENT ) > should be just: > +#define PAGE_HYPERVISOR_WC (DEV_WC | PTE_PRESENT ) > etc, no need for the inner-()s. > > MAP_SMALL_PAGES was correct as > +#define MAP_SMALL_PAGES (WRITEALLOC) I wanted to check the definition of MAP_SMALL_PAGES you were agreed. I think using WRITEALLOC here is confusing. There is no resulting PTE and therefore WRITEALLOC will never be set. I think it would be better to have a separate helper (as you suggested on a previous mail). Regards, -- Julien Grall