From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/2] xen: arm: log warning for interrupt configuration mismatch Date: Tue, 03 Mar 2015 12:20:50 +0000 Message-ID: <54F5A722.5060102@linaro.org> References: <1424359395.30924.89.camel@citrix.com> <1424359443-21584-1-git-send-email-ian.campbell@citrix.com> <54F23D65.8000602@linaro.org> <1425294756.1886.33.camel@citrix.com> <54F45E11.8070305@linaro.org> <1425315713.24959.17.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425315713.24959.17.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, Pranavkumar Sawargaonkar , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 02/03/2015 17:01, Ian Campbell wrote: > On Mon, 2015-03-02 at 12:56 +0000, Julien Grall wrote: > >>> From 852f6e3fe49f7fab801f2857b8b505922556d746 Mon Sep 17 00:00:00 2001 >>> From: Ian Campbell >>> Date: Mon, 2 Mar 2015 11:09:35 +0000 >>> Subject: [PATCH] xen: arm: Assume level triggered means high, not low. >>> >>> When reading back the ICFG register we cannot know the polarity of the >>> configuration, just that it is level or edge. >>> >>> Since falling edge and low level are invalid for SPIs we should assume >>> rising edge and high level (we have no better information for PPIs, so >>> it'll have to do). >>> >>> We already assumed rising edge, switch to high level as well. >>> >>> Signed-off-by: Ian Campbell >> >> Given the usage of desc->arch.type in Xen, I think this is the right >> solution: >> >> Reviewed-by: Julien Grall > > Applied, thanks. > > With your "don't warn if high-level" patch[*] is that all of the fallout > from this series, other than making desc->arch.type just track level vs > edge without polarity? Yes. Regards, -- Julien Grall