From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756547AbbCCNxj (ORCPT ); Tue, 3 Mar 2015 08:53:39 -0500 Received: from ns.iliad.fr ([212.27.33.1]:39048 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbbCCNxi (ORCPT ); Tue, 3 Mar 2015 08:53:38 -0500 Message-ID: <54F5BCE0.3060507@freebox.fr> Date: Tue, 03 Mar 2015 14:53:36 +0100 From: Nicolas Schichan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Eric Dumazet CC: "David S. Miller" , Tobias Klauser , Felipe Balbi , Wilfried Klaebe , "Eric W. Biederman" , Alexander Duyck , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcm63xx_enet: fix poll callback. References: <1425383112-23851-1-git-send-email-nschichan@freebox.fr> <1425389399.5130.169.camel@edumazet-glaptop2.roam.corp.google.com> <1425390142.5130.173.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1425390142.5130.173.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2015 02:42 PM, Eric Dumazet wrote: >> To avoid that, I would take priv->tx_lock only once, or add a limit on >> the number of skbs that can be drained per round. > > Something like this (untested) patch I'm not against testing this patch, but we do not have any SMP capable bcm63xx board here so I don't think it will be of any use. bcm6358 and bcm6368 do indeed have two MIPS threads, but SMP is not possible (due to a data cache or TLB shared across all MIPS threads , unbearably complicating things, IIRC). bcm63xx ARM SoCs look like they can support SMP though. Regards, -- Nicolas Schichan Freebox SAS