Re: [PATCH v2] ide_tape: convert jiffies with jiffies_to_msecs

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 3/3/2015 1:52 PM, Nicholas Mc Guire wrote:

> Use jiffies_to_msecs for converting jiffies as it handles all of the corner
> cases reliably and also helps readability. The printk format is fixed up
> as jiffies_to_msecs returns unsigned int not unsigned long.

> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---

> v2: change printk format string from %d to %u as suggested by
>      Joe Perches <joe@perches.com>.

> Note that this patch will give a checkpatch warning due to "quoted string
> split across lines" but thats not related to this change.

> This was only compile tested with x86_64_defconfig + CONFIG_IDE=m,
> CONFIG_BLK_DEV_IDETAPE=m

> Patch is against 4.0-rc1 (localversion-next is -next-20150303)
>
>   drivers/ide/ide-tape.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

    The driver is called ide-tape.c, yet your subject prefix is "ide_tape:".

WBR, Sergei