From: Fabien Lahoudere <fabienlahoudere.pro@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel
Date: Tue, 03 Mar 2015 15:25:24 +0100 [thread overview]
Message-ID: <54F5C454.9060208@gmail.com> (raw)
In-Reply-To: <20150303143125.75a1a4d3@free-electrons.com>
Hello
Thank you for the correction.
I will rework my patch but I have questions:
- If I change the title, and submit a new patch, what happened to the
old one in the patchwork?
- Is it necessary to prefix the new title with "PATCH v2"?
Fabien
Le 03/03/2015 14:31, Thomas Petazzoni a ?crit :
> Dear Lahoudere Fabien,
>
> On Tue, 3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
>> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro@gmail.com>
> This should normally be:
>
> Signed-off-by: <first name> <last name> <email>
>
>> ---
>> boot/barebox/barebox.mk | 2 ++
>> 1 file changed, 2 insertions(+)
> This looks good but the commit log could be improved:
>
> barebox: fix compilation on x86-64 architecture
>
> Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
> currently handle the case of the x86-64 architecture. In this
> case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
> nonetheless.
>
> The commit title should almost always look like:
>
> <pkg>: <description>
>
> Thanks,
>
> Thomas
prev parent reply other threads:[~2015-03-03 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:27 [Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel Lahoudere Fabien
2015-03-03 13:31 ` Thomas Petazzoni
2015-03-03 14:25 ` Fabien Lahoudere [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5C454.9060208@gmail.com \
--to=fabienlahoudere.pro@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.