From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 2/4] xen/arm: Check for interrupt controller directly Date: Tue, 03 Mar 2015 14:45:03 +0000 Message-ID: <54F5C8EF.5090507@linaro.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Frediano Ziglio , Ian Campbell , Stefano Stabellini , Tim Deegan Cc: zoltan.kiss@huawei.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hello Frediano, On 03/03/15 11:19, Frediano Ziglio wrote: > This check allow to detect mail interrupt controller even if it does main > not match one of the standard ones. > This allow boards with non standard controllers to be handled correctly > without having to manually edit the global list every time. > > Signed-off-by: Frediano Ziglio > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 9f1f59f..83951a3 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1069,7 +1069,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo, > > /* Replace these nodes with our own. Note that the original may be > * used_by DOMID_XEN so this check comes first. */ > - if ( dt_match_node(gic_matches, node) ) > + if ( node == dt_interrupt_controller || dt_match_node(gic_matches, node) ) > return make_gic_node(d, kinfo->fdt, node); What about if the device tree exposes multiple GICs? By mistake we will expose the secondaries GIC if they are not standard. As I suggested on a previous mail, I would prefer to introduce a new callback to check if the node is a GIC. Regards, -- Julien Grall