From: Max Reitz <mreitz@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, carnold@suse.com, jcody@redhat.com,
famz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/5] vpc: Ignore geometry for large images
Date: Tue, 03 Mar 2015 09:59:05 -0500 [thread overview]
Message-ID: <54F5CC39.7070603@redhat.com> (raw)
In-Reply-To: <1425379316-19639-3-git-send-email-pl@kamp.de>
On 2015-03-03 at 05:41, Peter Lieven wrote:
> From: Kevin Wolf <kwolf@redhat.com>
>
> The CHS calculation as done per the VHD spec imposes a maximum image
> size of ~127 GB. Real VHD images exist that are larger than that.
>
> Apparently there are two separate non-standard ways to achieve this:
> You could use more heads than the spec does - this is the option that
> qemu-img create chooses.
>
> However, other images exist where the geometry is set to the maximum
> (65535/16/255), but the actual image size is larger. Until now, such
> images are truncated at 127 GB when opening them with qemu.
>
> This patch changes the vpc driver to ignore geometry in this case and
> only trust the size field in the header.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> [PL: Fixed maximum geometry in the commit msg]
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/vpc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-03-03 14:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:41 [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations Peter Lieven
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 1/5] block/vpc: optimize vpc_co_get_block_status Peter Lieven
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 2/5] vpc: Ignore geometry for large images Peter Lieven
2015-03-03 14:59 ` Max Reitz [this message]
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 3/5] block/vpc: make calculate_geometry spec conform Peter Lieven
2015-03-03 15:05 ` Max Reitz
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 4/5] block/vpc: rename footer->size -> footer->current_size Peter Lieven
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 5/5] block/vpc: remove disabled code from get_sector_offset Peter Lieven
2015-03-03 15:07 ` Max Reitz
2015-03-03 21:03 ` [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations Max Reitz
2015-03-17 21:02 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5CC39.7070603@redhat.com \
--to=mreitz@redhat.com \
--cc=carnold@suse.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.