From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support
Date: Tue, 03 Mar 2015 15:53:56 +0000 [thread overview]
Message-ID: <54F5D914.7030705@arm.com> (raw)
In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com>
On 02/03/15 11:29, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>
> This patch separates the PMU driver code from the low level
> CCI driver code.
>
> Introduces config options for both.
>
> ARM_CCI400_PORT_CTRL - controls the low level driver code for
> CCI400 ports.
> ARM_CCI400_PMU - controls the PMU driver code
> ARM_CCI400_COMMON - Common defintions for CCI400
>
> Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This
> should be selected by platforms which need it.
>
> This patch also changes:
> ARM_CCI - common code for probing the CCI devices. This can be
> used for adding support for newer CCI versions(e.g, CCI-500).
>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
> arch/arm/mach-exynos/Kconfig | 2 +-
> arch/arm/mach-vexpress/Kconfig | 4 ++--
> drivers/bus/Kconfig | 27 +++++++++++++++++++++++----
> drivers/bus/arm-cci.c | 24 ++++++++++++++++++++----
> include/linux/arm-cci.h | 7 ++++++-
> 5 files changed, 52 insertions(+), 12 deletions(-)
>
[...]
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index b99729e..bdc189f 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT
> help
> Driver to enable OMAP interconnect error handling driver.
>
> -config ARM_CCI
> - bool "ARM CCI driver support"
> +config ARM_CCI400_PORT_CTRL
> + bool
> depends on ARM && OF && CPU_V7
> + select ARM_CCI400_COMMON
> + help
> + Low level power management driver for CCI400 cache coherent
> + interconnect for ARM platforms.
> +
> +config ARM_CCI400_PMU
> + bool "ARM CCI400 PMU support"
> + depends on ARM || ARM64
> + depends on HW_PERF_EVENTS
> + select ARM_CCI400_COMMON
> help
> - Driver supporting the CCI cache coherent interconnect for ARM
> - platforms.
> + Support for PMU events monitoring on the ARM CCI cache coherent
> + interconnect.
> +
> + If unsure, say N
Just a query rather than comment. Before this change all platforms
having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default.
With this change, one has to select this option explicitly. I assume
that's fine, else this needs to be default 'y'
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
To: "Suzuki K. Poulose" <suzuki.poulose-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Cc: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
"nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>,
Lorenzo Pieralisi
<Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Punit Agrawal <Punit.Agrawal-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support
Date: Tue, 03 Mar 2015 15:53:56 +0000 [thread overview]
Message-ID: <54F5D914.7030705@arm.com> (raw)
In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
On 02/03/15 11:29, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
>
> This patch separates the PMU driver code from the low level
> CCI driver code.
>
> Introduces config options for both.
>
> ARM_CCI400_PORT_CTRL - controls the low level driver code for
> CCI400 ports.
> ARM_CCI400_PMU - controls the PMU driver code
> ARM_CCI400_COMMON - Common defintions for CCI400
>
> Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This
> should be selected by platforms which need it.
>
> This patch also changes:
> ARM_CCI - common code for probing the CCI devices. This can be
> used for adding support for newer CCI versions(e.g, CCI-500).
>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
> ---
> arch/arm/mach-exynos/Kconfig | 2 +-
> arch/arm/mach-vexpress/Kconfig | 4 ++--
> drivers/bus/Kconfig | 27 +++++++++++++++++++++++----
> drivers/bus/arm-cci.c | 24 ++++++++++++++++++++----
> include/linux/arm-cci.h | 7 ++++++-
> 5 files changed, 52 insertions(+), 12 deletions(-)
>
[...]
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index b99729e..bdc189f 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT
> help
> Driver to enable OMAP interconnect error handling driver.
>
> -config ARM_CCI
> - bool "ARM CCI driver support"
> +config ARM_CCI400_PORT_CTRL
> + bool
> depends on ARM && OF && CPU_V7
> + select ARM_CCI400_COMMON
> + help
> + Low level power management driver for CCI400 cache coherent
> + interconnect for ARM platforms.
> +
> +config ARM_CCI400_PMU
> + bool "ARM CCI400 PMU support"
> + depends on ARM || ARM64
> + depends on HW_PERF_EVENTS
> + select ARM_CCI400_COMMON
> help
> - Driver supporting the CCI cache coherent interconnect for ARM
> - platforms.
> + Support for PMU events monitoring on the ARM CCI cache coherent
> + interconnect.
> +
> + If unsure, say N
Just a query rather than comment. Before this change all platforms
having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default.
With this change, one has to select this option explicitly. I assume
that's fine, else this needs to be default 'y'
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"nico@linaro.org" <nico@linaro.org>,
"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
"kgene@kernel.org" <kgene@kernel.org>,
"a.kesavan@samsung.com" <a.kesavan@samsung.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>,
"olof@lixom.net" <olof@lixom.net>,
Punit Agrawal <Punit.Agrawal@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support
Date: Tue, 03 Mar 2015 15:53:56 +0000 [thread overview]
Message-ID: <54F5D914.7030705@arm.com> (raw)
In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com>
On 02/03/15 11:29, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>
> This patch separates the PMU driver code from the low level
> CCI driver code.
>
> Introduces config options for both.
>
> ARM_CCI400_PORT_CTRL - controls the low level driver code for
> CCI400 ports.
> ARM_CCI400_PMU - controls the PMU driver code
> ARM_CCI400_COMMON - Common defintions for CCI400
>
> Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This
> should be selected by platforms which need it.
>
> This patch also changes:
> ARM_CCI - common code for probing the CCI devices. This can be
> used for adding support for newer CCI versions(e.g, CCI-500).
>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
> arch/arm/mach-exynos/Kconfig | 2 +-
> arch/arm/mach-vexpress/Kconfig | 4 ++--
> drivers/bus/Kconfig | 27 +++++++++++++++++++++++----
> drivers/bus/arm-cci.c | 24 ++++++++++++++++++++----
> include/linux/arm-cci.h | 7 ++++++-
> 5 files changed, 52 insertions(+), 12 deletions(-)
>
[...]
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index b99729e..bdc189f 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT
> help
> Driver to enable OMAP interconnect error handling driver.
>
> -config ARM_CCI
> - bool "ARM CCI driver support"
> +config ARM_CCI400_PORT_CTRL
> + bool
> depends on ARM && OF && CPU_V7
> + select ARM_CCI400_COMMON
> + help
> + Low level power management driver for CCI400 cache coherent
> + interconnect for ARM platforms.
> +
> +config ARM_CCI400_PMU
> + bool "ARM CCI400 PMU support"
> + depends on ARM || ARM64
> + depends on HW_PERF_EVENTS
> + select ARM_CCI400_COMMON
> help
> - Driver supporting the CCI cache coherent interconnect for ARM
> - platforms.
> + Support for PMU events monitoring on the ARM CCI cache coherent
> + interconnect.
> +
> + If unsure, say N
Just a query rather than comment. Before this change all platforms
having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default.
With this change, one has to select this option explicitly. I assume
that's fine, else this needs to be default 'y'
Regards,
Sudeep
next prev parent reply other threads:[~2015-03-03 15:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 11:29 [PATCH v2 0/5] arm-cci400: PMU monitoring support on ARM64 Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-02 11:29 ` [PATCH 1/5] arm-cci: Rearrange code for splitting PMU vs driver code Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-03 15:35 ` Sudeep Holla
2015-03-03 15:35 ` Sudeep Holla
2015-03-04 12:16 ` Suzuki K. Poulose
2015-03-04 12:16 ` Suzuki K. Poulose
2015-03-04 12:16 ` Suzuki K. Poulose
2015-03-02 11:29 ` [PATCH 2/5] arm-cci: Abstract the CCI400 PMU speicific definitions Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-02 11:29 ` [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-03 15:44 ` Sudeep Holla
2015-03-03 15:44 ` Sudeep Holla
2015-03-04 17:52 ` Suzuki K. Poulose
2015-03-04 17:52 ` Suzuki K. Poulose
2015-03-02 11:29 ` [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-03 15:53 ` Sudeep Holla [this message]
2015-03-03 15:53 ` Sudeep Holla
2015-03-03 15:53 ` Sudeep Holla
2015-03-04 12:18 ` Suzuki K. Poulose
2015-03-04 12:18 ` Suzuki K. Poulose
2015-03-02 11:29 ` [PATCH 5/5] arm-cci: Fix CCI PMU event validation Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-02 11:29 ` Suzuki K. Poulose
2015-03-03 16:00 ` [PATCH v2 0/5] arm-cci400: PMU monitoring support on ARM64 Sudeep Holla
2015-03-03 16:00 ` Sudeep Holla
2015-03-03 16:00 ` Sudeep Holla
2015-03-04 12:17 ` Suzuki K. Poulose
2015-03-04 12:17 ` Suzuki K. Poulose
-- strict thread matches above, loose matches on Subject: below --
2015-03-10 15:18 [PATCHv3 " Suzuki K. Poulose
2015-03-10 15:18 ` [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 16:24 ` Sudeep Holla
2015-03-18 12:24 [PATCHv4 0/5] arm-cci400: PMU monitoring support on ARM64 Suzuki K. Poulose
[not found] ` <1426681482-23118-1-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-18 12:24 ` [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Suzuki K. Poulose
2015-03-18 12:24 ` Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5D914.7030705@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.