From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Tue, 03 Mar 2015 15:53:56 +0000 Subject: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com> References: <1425295754-13376-1-git-send-email-suzuki.poulose@arm.com> <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com> Message-ID: <54F5D914.7030705@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/03/15 11:29, Suzuki K. Poulose wrote: > From: "Suzuki K. Poulose" > > This patch separates the PMU driver code from the low level > CCI driver code. > > Introduces config options for both. > > ARM_CCI400_PORT_CTRL - controls the low level driver code for > CCI400 ports. > ARM_CCI400_PMU - controls the PMU driver code > ARM_CCI400_COMMON - Common defintions for CCI400 > > Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This > should be selected by platforms which need it. > > This patch also changes: > ARM_CCI - common code for probing the CCI devices. This can be > used for adding support for newer CCI versions(e.g, CCI-500). > > Signed-off-by: Suzuki K. Poulose > --- > arch/arm/mach-exynos/Kconfig | 2 +- > arch/arm/mach-vexpress/Kconfig | 4 ++-- > drivers/bus/Kconfig | 27 +++++++++++++++++++++++---- > drivers/bus/arm-cci.c | 24 ++++++++++++++++++++---- > include/linux/arm-cci.h | 7 ++++++- > 5 files changed, 52 insertions(+), 12 deletions(-) > [...] > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index b99729e..bdc189f 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT > help > Driver to enable OMAP interconnect error handling driver. > > -config ARM_CCI > - bool "ARM CCI driver support" > +config ARM_CCI400_PORT_CTRL > + bool > depends on ARM && OF && CPU_V7 > + select ARM_CCI400_COMMON > + help > + Low level power management driver for CCI400 cache coherent > + interconnect for ARM platforms. > + > +config ARM_CCI400_PMU > + bool "ARM CCI400 PMU support" > + depends on ARM || ARM64 > + depends on HW_PERF_EVENTS > + select ARM_CCI400_COMMON > help > - Driver supporting the CCI cache coherent interconnect for ARM > - platforms. > + Support for PMU events monitoring on the ARM CCI cache coherent > + interconnect. > + > + If unsure, say N Just a query rather than comment. Before this change all platforms having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default. With this change, one has to select this option explicitly. I assume that's fine, else this needs to be default 'y' Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Date: Tue, 03 Mar 2015 15:53:56 +0000 Message-ID: <54F5D914.7030705@arm.com> References: <1425295754-13376-1-git-send-email-suzuki.poulose@arm.com> <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Suzuki K. Poulose" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" Cc: Sudeep Holla , "nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Liviu Dudau , Lorenzo Pieralisi , Pawel Moll , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , Punit Agrawal , Will Deacon , Catalin Marinas List-Id: devicetree@vger.kernel.org On 02/03/15 11:29, Suzuki K. Poulose wrote: > From: "Suzuki K. Poulose" > > This patch separates the PMU driver code from the low level > CCI driver code. > > Introduces config options for both. > > ARM_CCI400_PORT_CTRL - controls the low level driver code for > CCI400 ports. > ARM_CCI400_PMU - controls the PMU driver code > ARM_CCI400_COMMON - Common defintions for CCI400 > > Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This > should be selected by platforms which need it. > > This patch also changes: > ARM_CCI - common code for probing the CCI devices. This can be > used for adding support for newer CCI versions(e.g, CCI-500). > > Signed-off-by: Suzuki K. Poulose > --- > arch/arm/mach-exynos/Kconfig | 2 +- > arch/arm/mach-vexpress/Kconfig | 4 ++-- > drivers/bus/Kconfig | 27 +++++++++++++++++++++++---- > drivers/bus/arm-cci.c | 24 ++++++++++++++++++++---- > include/linux/arm-cci.h | 7 ++++++- > 5 files changed, 52 insertions(+), 12 deletions(-) > [...] > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index b99729e..bdc189f 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT > help > Driver to enable OMAP interconnect error handling driver. > > -config ARM_CCI > - bool "ARM CCI driver support" > +config ARM_CCI400_PORT_CTRL > + bool > depends on ARM && OF && CPU_V7 > + select ARM_CCI400_COMMON > + help > + Low level power management driver for CCI400 cache coherent > + interconnect for ARM platforms. > + > +config ARM_CCI400_PMU > + bool "ARM CCI400 PMU support" > + depends on ARM || ARM64 > + depends on HW_PERF_EVENTS > + select ARM_CCI400_COMMON > help > - Driver supporting the CCI cache coherent interconnect for ARM > - platforms. > + Support for PMU events monitoring on the ARM CCI cache coherent > + interconnect. > + > + If unsure, say N Just a query rather than comment. Before this change all platforms having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default. With this change, one has to select this option explicitly. I assume that's fine, else this needs to be default 'y' Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbbCCPyC (ORCPT ); Tue, 3 Mar 2015 10:54:02 -0500 Received: from service87.mimecast.com ([91.220.42.44]:36390 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbbCCPx7 convert rfc822-to-8bit (ORCPT ); Tue, 3 Mar 2015 10:53:59 -0500 Message-ID: <54F5D914.7030705@arm.com> Date: Tue, 03 Mar 2015 15:53:56 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Suzuki K. Poulose" , "linux-arm-kernel@lists.infradead.org" CC: Sudeep Holla , "nico@linaro.org" , "b.zolnierkie@samsung.com" , "kgene@kernel.org" , "a.kesavan@samsung.com" , "arnd@arndb.de" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Liviu Dudau , Lorenzo Pieralisi , Pawel Moll , "olof@lixom.net" , Punit Agrawal , Will Deacon , Catalin Marinas Subject: Re: [PATCH 4/5] arm-cci: Split the code for PMU vs driver support References: <1425295754-13376-1-git-send-email-suzuki.poulose@arm.com> <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com> In-Reply-To: <1425295754-13376-5-git-send-email-suzuki.poulose@arm.com> X-OriginalArrivalTime: 03 Mar 2015 15:53:54.0028 (UTC) FILETIME=[400FDAC0:01D055CA] X-MC-Unique: 115030315535701101 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/15 11:29, Suzuki K. Poulose wrote: > From: "Suzuki K. Poulose" > > This patch separates the PMU driver code from the low level > CCI driver code. > > Introduces config options for both. > > ARM_CCI400_PORT_CTRL - controls the low level driver code for > CCI400 ports. > ARM_CCI400_PMU - controls the PMU driver code > ARM_CCI400_COMMON - Common defintions for CCI400 > > Also the ARM_CCI400_PORT_CTRL cannot be enabled by user. This > should be selected by platforms which need it. > > This patch also changes: > ARM_CCI - common code for probing the CCI devices. This can be > used for adding support for newer CCI versions(e.g, CCI-500). > > Signed-off-by: Suzuki K. Poulose > --- > arch/arm/mach-exynos/Kconfig | 2 +- > arch/arm/mach-vexpress/Kconfig | 4 ++-- > drivers/bus/Kconfig | 27 +++++++++++++++++++++++---- > drivers/bus/arm-cci.c | 24 ++++++++++++++++++++---- > include/linux/arm-cci.h | 7 ++++++- > 5 files changed, 52 insertions(+), 12 deletions(-) > [...] > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index b99729e..bdc189f 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -43,12 +43,31 @@ config OMAP_INTERCONNECT > help > Driver to enable OMAP interconnect error handling driver. > > -config ARM_CCI > - bool "ARM CCI driver support" > +config ARM_CCI400_PORT_CTRL > + bool > depends on ARM && OF && CPU_V7 > + select ARM_CCI400_COMMON > + help > + Low level power management driver for CCI400 cache coherent > + interconnect for ARM platforms. > + > +config ARM_CCI400_PMU > + bool "ARM CCI400 PMU support" > + depends on ARM || ARM64 > + depends on HW_PERF_EVENTS > + select ARM_CCI400_COMMON > help > - Driver supporting the CCI cache coherent interconnect for ARM > - platforms. > + Support for PMU events monitoring on the ARM CCI cache coherent > + interconnect. > + > + If unsure, say N Just a query rather than comment. Before this change all platforms having ARM_CCI and HW_PERF_EVENTS had CCI PMU enabled by default. With this change, one has to select this option explicitly. I assume that's fine, else this needs to be default 'y' Regards, Sudeep