All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <dsg_gchen_5257@sohu.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-mm@kvack.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chen Gang <762976180@qq.com>
Subject: Re: [PATCH] mm: memcontrol: Let mem_cgroup_move_account() have effect only if MMU enabled
Date: Wed, 04 Mar 2015 04:01:04 +0800	[thread overview]
Message-ID: <54F61300.1070409@sohu.com> (raw)
In-Reply-To: <20150303134524.GE2409@dhcp22.suse.cz>

On 3/3/15 21:45, Michal Hocko wrote:
> On Tue 03-03-15 06:42:01, Chen Gang wrote:
>> When !MMU, it will report warning. The related warning with allmodconfig
>> under c6x:
> 
> Does it even make any sense to enable CONFIG_MEMCG when !CONFIG_MMU?
> Is anybody using this configuration and is it actually usable? My
> knowledge about CONFIG_MMU is close to zero so I might be missing
> something but I do not see a point into fixing compile warnings when
> the whole subsystem is not usable in the first place.
> 

For me, only according to the current code, the original author assumes
CONFIG_MEMCG can still have effect when !CONFIG_MMU: "or, he/she needn't
use CONFIG_MMU switch macro in memcontrol.c".

Welcome any other members' ideas, too.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-03-03 20:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 22:42 [PATCH] mm: memcontrol: Let mem_cgroup_move_account() have effect only if MMU enabled Chen Gang
2015-03-02 22:46 ` Fwd: " Chen Gang S
     [not found] ` <54F4E739.6040805-9uewiaClKEY@public.gmane.org>
2015-03-03 13:45   ` Michal Hocko
2015-03-03 13:45     ` Michal Hocko
2015-03-03 13:45     ` Michal Hocko
2015-03-03 20:01     ` Chen Gang [this message]
2015-03-04  9:59       ` Michal Hocko
2015-03-04  9:59         ` Michal Hocko
2015-03-04  9:59         ` Michal Hocko
     [not found]     ` <20150303134524.GE2409-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-03-04 17:40       ` Johannes Weiner
2015-03-04 17:40         ` Johannes Weiner
2015-03-04 17:40         ` Johannes Weiner
     [not found]         ` <20150304174056.GA20376-HTCKtW7iVlxqnrmGgq4/JMIURNUf+fel@public.gmane.org>
2015-03-04 18:00           ` Michal Hocko
2015-03-04 18:00             ` Michal Hocko
2015-03-04 18:00             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F61300.1070409@sohu.com \
    --to=dsg_gchen_5257@sohu.com \
    --cc=762976180@qq.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.