All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 1/4] pinctrl: tegra: driver layout/consistency fixes
Date: Tue, 03 Mar 2015 13:21:01 -0700	[thread overview]
Message-ID: <54F617AD.6070208@wwwdotorg.org> (raw)
In-Reply-To: <1424811651-18660-1-git-send-email-swarren@wwwdotorg.org>

On 02/24/2015 02:00 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Various non-semantic tweaks and layout/consistency fixes for existing
> Tegra pinctrl drivers.
>
> Move the definition of DRV_PINGROUP_REG() before the definition of
> PINGROUP() so that a future SoC driver can invoke the former from the
> latter.
>
> PINGROUP_BIT_Y(n) is just n, so replace it with n.
>
> Re-wrap the parameters to *PINGROUP().
>
> Keep various enums sorted in the Tegra124 driver.
>
> Various white-space consistency fixes.
>
> These changes aim to update existing drivers to be consistent with future
> SoC drivers. While we could ignore these tweaks to the existing drivers,
> I'd like to keep everything as consistent as possible for easy comparison.
> Besides, I auto-generate the drivers, and maintaining special-cases to
> keep the differences in place is annoying.

Linus, does this series look OK?

  parent reply	other threads:[~2015-03-03 20:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 21:00 [PATCH 1/4] pinctrl: tegra: driver layout/consistency fixes Stephen Warren
2015-02-24 21:00 ` Stephen Warren
2015-02-24 21:00 ` [PATCH 2/4] pinctrl: tegra: some bits move between registers Stephen Warren
2015-03-07 20:09   ` Linus Walleij
2015-02-24 21:00 ` [PATCH 3/4] pinctrl: tegra: support nvidia,io-hv DT property Stephen Warren
2015-03-07 20:10   ` Linus Walleij
2015-03-09 15:58     ` Stephen Warren
2015-02-24 21:00 ` [PATCH 4/4] pinctrl: tegra: add a driver for Tegra210 Stephen Warren
2015-03-03  5:47   ` Alexandre Courbot
2015-03-03 20:21 ` Stephen Warren [this message]
2015-03-07 20:08 ` [PATCH 1/4] pinctrl: tegra: driver layout/consistency fixes Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F617AD.6070208@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.