All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "linux-rdma
	(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration
Date: Tue, 03 Mar 2015 15:23:05 -0500	[thread overview]
Message-ID: <54F61829.3070903@dev.mellanox.co.il> (raw)


This causes it to be a global variable which causes linking
issues when used by multiple files linked together. It results
in multiple definition of `umad_reg_flags'.

Found-by: Rafi Weiner <rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/include/infiniband/umad.h b/include/infiniband/umad.h
index 6c3e7dc..1db4505 100644
--- a/include/infiniband/umad.h
+++ b/include/infiniband/umad.h
@@ -201,7 +201,7 @@ int umad_unregister(int portid, int agentid);
 
 enum {
 	UMAD_USER_RMPP = (1 << 0)
-} umad_reg_flags;
+};
 
 struct umad_reg_attr {
 	uint8_t    mgmt_class;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2015-03-03 20:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 20:23 Hal Rosenstock [this message]
     [not found] ` <54F61829.3070903-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-03-03 20:33   ` [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration Weiny, Ira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F61829.3070903@dev.mellanox.co.il \
    --to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.