From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSuxa-0004qx-14 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 17:06:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSuxU-0001LR-H5 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 17:06:37 -0500 Message-ID: <54F63062.401@redhat.com> Date: Tue, 03 Mar 2015 15:06:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425417759-17170-1-git-send-email-mreitz@redhat.com> <1425417759-17170-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1425417759-17170-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OMoHqedXloMuV2onCCAmJgMf1K3C4MVn0" Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Peter Lieven , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OMoHqedXloMuV2onCCAmJgMf1K3C4MVn0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/03/2015 02:22 PM, Max Reitz wrote: > Both tests require the test image to have a specific size; this cannot > be guaranteed by vpc (unless tuning the test specifically for that > format). >=20 > It is safe to exclude vpc from 004 because what is tested there is > implemented in a generic part in the block layer and not > format-specific. >=20 > It is safe to exclude vpc from 104 because for vpc basically every imag= e > size is "unaligned", so if that would break at some point in time, we > would quickly notice just by running the generic tests. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/004 | 2 +- > tests/qemu-iotests/104 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OMoHqedXloMuV2onCCAmJgMf1K3C4MVn0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU9jBiAAoJEKeha0olJ0NqmZ4IAIMnwlQkngo3d3cXdNQ7dRCN lWK+57AleALaKtwasWQslvoSByv920L1ykq+hFScsrXwtds506Pyr4dETr3FWgEJ 3LdFyDssAsa51DYbjxCyDrGq3EZvzd4u3pLjhDt3Nes6GrT/OF9IxHlOmmFAo/Zi HOlSQlnJ81YuVpOY50MRbMfOjH3zTyziStMq/X86GUbJ+qqSWxJfhFLinmSfisXR nLenn7sTemLUDuRlfUq2d/S6uarPjvIEDcntbXis0kc/M9de7ivig73/C+NubiDv vkNRImsgEFk6nL8Zne+nQAqjoKt2kqzvHxUOVWNEGQmB6div+CDZZxKgYdjPKsI= =oOQT -----END PGP SIGNATURE----- --OMoHqedXloMuV2onCCAmJgMf1K3C4MVn0--