From: Jens Axboe <axboe@kernel.dk>
To: Christian Ehrhardt <ehrhardt@de.ibm.com>, fio@vger.kernel.org
Cc: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Subject: Re: [PATCH] fio: fix smalloc strdop allocation failure
Date: Tue, 03 Mar 2015 15:09:27 -0700 [thread overview]
Message-ID: <54F63117.7000601@kernel.dk> (raw)
In-Reply-To: <1425383086-9188-1-git-send-email-ehrhardt@de.ibm.com>
On 03/03/2015 04:44 AM, Christian Ehrhardt wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
> smalloc_strdup didn't check for allocation success and thereby ran into
> segfaults if the single pool went out of memory.
> Now with this patch applied it is still failing, but in a more consistent
> way than segfaulting.
>
> You still get a bad allocation, but it looks like this now:
> fio: smalloc OOM
> fio: filesetup.c:1495: dup_files: Assertion `0' failed.
> Aborted
>
> In fact the upper layers expected smalloc_strdup to retrun NULL on failure.
>
> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2015-03-03 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 11:44 [PATCH] fio: fix smalloc strdop allocation failure Christian Ehrhardt
2015-03-03 22:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F63117.7000601@kernel.dk \
--to=axboe@kernel.dk \
--cc=ehrhardt@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.