From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 2/4] drm/msm/mdp5: Enhance operation mode for pipeline configuration Date: Wed, 04 Mar 2015 11:52:54 +0530 Message-ID: <54F6A4BE.1070104@codeaurora.org> References: <1425407775-7704-1-git-send-email-sviau@codeaurora.org> <1425407775-7704-3-git-send-email-sviau@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1425407775-7704-3-git-send-email-sviau@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stephane Viau , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org SGksCgpPbiAwMy8wNC8yMDE1IDEyOjA2IEFNLCBTdGVwaGFuZSBWaWF1IHdyb3RlOgo+IERTSSBh bmQgV0IgaW50ZXJmYWNlcyBuZWVkIGEgbW9yZSBjb21wbGV4IHBpcGVsaW5lIGNvbmZpZ3VyYXRp b24KPiB0aGFuIHRoZSBjdXJyZW50IG1kcDVfY3RsX3NldF9pbnRmKCkuCj4KPiBGb3IgZXhhbXBs ZSwgbWVtb3J5IG91dHB1dCBjb25uZWN0aW9ucyBuZWVkIHRvIGJlIHNlbGVjdGVkIGZvcgo+IFdC LiBJbnRlcmZhY2UgbW9kZSAoVmlkZW8gdnMuIENvbW1hbmQgbW9kZXMpIGFsc28gbmVlZCB0byBi ZQo+IGNvbmZpZ3VyZWQgZm9yIERTSS4KPgo+IFRoaXMgY2hhbmdlIHRha2VzIGNhcmUgb2YgY29u ZmlndXJpbmcgdGhlIHdob2xlIHBpcGVsaW5lIGFzIGZhcgo+IGFzIG9wZXJhdGlvbiBtb2RlIGdv ZXMuIERTSSBhbmQgV0IgaW50ZXJmYWNlcyB3aWxsIGJlIGFkZGVkCj4gbGF0ZXIuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBTdGVwaGFuZSBWaWF1IDxzdmlhdUBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9jZmcuaCAgICAgfCAgMiArCj4gICBk cml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfY3J0Yy5jICAgIHwgMzkgKystLS0tLS0t LS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X2N0bC5jICAgICB8IDkx ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL21k cC9tZHA1L21kcDVfY3RsLmggICAgIHwgIDMgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRw L21kcDUvbWRwNV9lbmNvZGVyLmMgfCAyOSArKysrKy0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9t c20vbWRwL21kcDUvbWRwNV9rbXMuYyAgICAgfCAxNiArKysrLQo+ICAgZHJpdmVycy9ncHUvZHJt L21zbS9tZHAvbWRwNS9tZHA1X2ttcy5oICAgICB8IDQ4ICsrKysrKysrKysrKy0tLQo+ICAgNyBm aWxlcyBjaGFuZ2VkLCAxNTcgaW5zZXJ0aW9ucygrKSwgNzEgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X2NmZy5oIGIvZHJpdmVy cy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X2NmZy5oCj4gaW5kZXggZGJhNGQ1Mi4uYmU1ODdi OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfY2ZnLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfY2ZnLmgKPiBAQCAtMzEs NiArMzEsOCBAQCBleHRlcm4gY29uc3Qgc3RydWN0IG1kcDVfY2ZnX2h3ICptZHA1X2NmZzsKPgo+ ICAgdHlwZWRlZiBERUNMQVJFX0JJVE1BUChtZHA1X3NtcF9zdGF0ZV90LCBNQVhfU01QX0JMT0NL Uyk7Cj4KPiArI2RlZmluZSBNRFA1X0lOVEZfSVNfVklSVFVBTF9ESVNQTEFZKGludGZfdHlwZSkg ICAoKGludGZfdHlwZSkgPj0gSU5URl9WSVJUVUFMKQo+ICsKCk1pbm9yIGNvbW1lbnQgYW5kIHBy b2JhYmx5IG1hdHRlciBvZiB0YXN0ZS4gSGF2aW5nIHRoZSBhYm92ZSBhcyAKbWRwNV9pbnRmX2lz X3ZpcnR1YWwoKSB3b3VsZCBzZWVtIGJldHRlciBpbiB0aGUgY29kZS4KCjxzbmlwPgoKVGhhbmtz LApBcmNoaXQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758196AbbCDGXD (ORCPT ); Wed, 4 Mar 2015 01:23:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42877 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbbCDGW7 (ORCPT ); Wed, 4 Mar 2015 01:22:59 -0500 Message-ID: <54F6A4BE.1070104@codeaurora.org> Date: Wed, 04 Mar 2015 11:52:54 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Stephane Viau , dri-devel@lists.freedesktop.org CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com Subject: Re: [PATCH 2/4] drm/msm/mdp5: Enhance operation mode for pipeline configuration References: <1425407775-7704-1-git-send-email-sviau@codeaurora.org> <1425407775-7704-3-git-send-email-sviau@codeaurora.org> In-Reply-To: <1425407775-7704-3-git-send-email-sviau@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/04/2015 12:06 AM, Stephane Viau wrote: > DSI and WB interfaces need a more complex pipeline configuration > than the current mdp5_ctl_set_intf(). > > For example, memory output connections need to be selected for > WB. Interface mode (Video vs. Command modes) also need to be > configured for DSI. > > This change takes care of configuring the whole pipeline as far > as operation mode goes. DSI and WB interfaces will be added > later. > > Signed-off-by: Stephane Viau > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 2 + > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 39 ++----------- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 91 +++++++++++++++++++++++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 3 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 29 +++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 16 ++++- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 48 ++++++++++++--- > 7 files changed, 157 insertions(+), 71 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > index dba4d52..be587b8 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > @@ -31,6 +31,8 @@ extern const struct mdp5_cfg_hw *mdp5_cfg; > > typedef DECLARE_BITMAP(mdp5_smp_state_t, MAX_SMP_BLOCKS); > > +#define MDP5_INTF_IS_VIRTUAL_DISPLAY(intf_type) ((intf_type) >= INTF_VIRTUAL) > + Minor comment and probably matter of taste. Having the above as mdp5_intf_is_virtual() would seem better in the code. Thanks, Archit