From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT4f9-0000Ve-BF for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:28:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT4f4-0001Li-Q8 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:28:15 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:50348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT4f4-0001LI-GY for qemu-devel@nongnu.org; Wed, 04 Mar 2015 03:28:10 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Mar 2015 08:28:08 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id D04E91B0806E for ; Wed, 4 Mar 2015 08:28:22 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t248S52Y8716630 for ; Wed, 4 Mar 2015 08:28:05 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t248S4pC030386 for ; Wed, 4 Mar 2015 01:28:04 -0700 Message-ID: <54F6C213.10004@de.ibm.com> Date: Wed, 04 Mar 2015 09:28:03 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1425061147-1411-1-git-send-email-stefanha@redhat.com> <54F5EF8F.7000802@de.ibm.com> <54F5F04C.2060205@redhat.com> In-Reply-To: <54F5F04C.2060205@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/69] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Ekaterina Tumanova Cc: Stefan Hajnoczi , qemu-devel , Markus Armbruster , Max Reitz Am 03.03.2015 um 18:33 schrieb Max Reitz: > On 2015-03-03 at 12:29, Christian Borntraeger wrote: >> Am 03.03.2015 um 15:52 schrieb Peter Maydell: >>> On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: >>>> On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote: >>>>> Ekaterina Tumanova (5): >>>>> block: add bdrv functions for geometry and blocksize >>>>> raw-posix: Factor block size detection out of raw_probe_alignment() >>>>> block: Add driver methods to probe blocksizes and geometry >>>>> block-backend: Add wrappers for blocksizes and geometry probing >>>>> BlockConf: Call backend functions to detect geometry and blocksizes >>>> Max Reitz found an issue with this patch. >>>> >>>> Peter: Please squash the following trivial fix into "BlockConf: Call >>>> backend functions to detect geometry and blocksizes": >>>> https://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg05512.html >>> I can't squash fixes into pull requests -- I can only >>> apply them, or not apply them. You need to respin. >>> >>>> I want to avoid spamming the list with another 60 patches. >>> If it's a trivial change since last time around you can just >>> send the cover letter to the list with a note in it that there >>> have only been small changes. >>> >>> -- PMM >>> >> I think you could just apply this pull request and add the fixup as separate >> patch. >> After all it fixes a case were the command line is wrong, so should not >> on the critical path - I guess. > > I agree. It's not nice to have a known break, but we're a bit behind on the pull requests already... Also, the segfault is always caused by dereferencing a null pointer, so there is no security issue. Peter, unless Stefan/Kevin object: can you pull the original pull request? Kate, can you resend patch " scsi-hd: fix property unset case" with an additional comment as Markus suggested directly to Peter Maydell, cc Stefan/Kevin/Max/Markus/qemu-devel? Christian