From: David Vrabel <david.vrabel@citrix.com>
To: Tao Chen <boby.chen@huawei.com>,
jgross@suse.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com
Cc: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, wu.wubin@huawei.com,
rudy.zhangmin@huawei.com
Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK
Date: Wed, 4 Mar 2015 10:34:31 +0000 [thread overview]
Message-ID: <54F6DFB7.2080402@citrix.com> (raw)
In-Reply-To: <1425493951-41801-1-git-send-email-boby.chen@huawei.com>
On 04/03/15 18:32, Tao Chen wrote:
> Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK.
> Also fixed up some comments just as eliminate redundant white spaces and format the code.
> These will make the code easier to read.
I have already said you needed to use:
#define pr_fmt(fmt)
to do this.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Tao Chen <boby.chen@huawei.com>, <jgross@suse.com>,
<konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <wu.wubin@huawei.com>,
<rudy.zhangmin@huawei.com>
Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK
Date: Wed, 4 Mar 2015 10:34:31 +0000 [thread overview]
Message-ID: <54F6DFB7.2080402@citrix.com> (raw)
In-Reply-To: <1425493951-41801-1-git-send-email-boby.chen@huawei.com>
On 04/03/15 18:32, Tao Chen wrote:
> Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK.
> Also fixed up some comments just as eliminate redundant white spaces and format the code.
> These will make the code easier to read.
I have already said you needed to use:
#define pr_fmt(fmt)
to do this.
David
next prev parent reply other threads:[~2015-03-04 10:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 18:32 [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK Tao Chen
2015-03-04 18:32 ` Tao Chen
2015-03-04 10:34 ` David Vrabel [this message]
2015-03-04 10:34 ` David Vrabel
2015-03-06 9:39 ` Chentao (Boby)
2015-03-06 9:39 ` Chentao (Boby)
2015-03-06 9:39 ` Chentao (Boby)
2015-03-04 10:34 ` David Vrabel
2015-03-04 16:32 ` Joe Perches
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 12:50 ` Joe Perches
2015-03-09 13:59 ` Chentao (Boby)
2015-03-09 13:59 ` Chentao (Boby)
2015-03-09 13:59 ` Chentao (Boby)
2015-03-06 12:50 ` Joe Perches
2015-03-04 16:32 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-03-04 18:32 Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6DFB7.2080402@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boby.chen@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rudy.zhangmin@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.