All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] lcd-console / display rotation
Date: Wed, 04 Mar 2015 13:58:21 +0200	[thread overview]
Message-ID: <54F6F35D.3070005@compulab.co.il> (raw)
In-Reply-To: <OF0F521722.E0FEAF83-ONC1257DFD.00394289-C1257DFD.0039CB78@br-automation.com>

Hi Hannes,

On 03/03/2015 12:31 PM, Hannes Petermaier wrote:
>>
>> +Anatolij, Nikita
>>
>> Hi,
> Hi,
> many thanks for response.
>
>>
>> On 2 March 2015 at 03:12, Hannes Petermaier
>> <Hannes.Petermaier@br-automation.com> wrote:
>>> Hello everybody,
>>>
>>> A short question about lcd-console:
>>>
>>> Today u-boot only supports a 'linear framebuffer', meaning the next
> pixel
>>> of a character is allways right after left and the framebuffer address
> is
>>> incrementing.
>>> We call this the display is mounted with 0? rotation.
>>>
>>> In some cases we have a rotated display.
>>> Maybe rotated by 90? to have portrait mode or even 180? due to
> mechanical
>>> issues.
>>>
>>> My question is:
>>> Is anybody currently working around this, having rotated display ?
>>> If not so, i would like start a implementation.
>>>
>>> 180? is quite easy, we only need to add some offset (total len of
>>> framebuffer) to our framebuffer base address and do -- instead ++ for
>>> drawing characters. Font can be reused.
>>>
>>> In the other cases, 90? and 270? it will maybe a bit tricky. I think a
>>> ?rotated font? is also necessary.
>>>
>>> Of course we have to think about the other functions like scroll
> up/down.
>>
>> I don't know of anything, but it sounds useful.
> Okay, Anatolij doesn't also know anything that there is something going
> on.
> I will start to form some ideas how to implement such feature.
>
>>
>> Also I wonder if some hardware has support for this?
> "Support" is the wrong word, sometimes the the lcd is mechanical built in
> rotated and the logical start of the framebuffer isn't as usual at
> top-left, rather it it bottom-right - means rotated by 180?.
>>
>> Nikita (on CC) is tidying up this part of U-Boot so get in touch with
> him.
> Nikita, whats your opinion around that ?

Sounds like a useful feature. I do not anticipate much changes to lcd_console.c
in the near future (not until I try to merge video console with the lcd console
anyway), so for now you can work with it fairly uninterrupted. I only ask that
you avoid adding platform specific code to it. The only platform specific thing
in there right now is a mention of panel_info, and that should disappear soon
as well (replaced with a function call).

-- 
Regards,
Nikita Kiryanov

  reply	other threads:[~2015-03-04 11:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 10:12 [U-Boot] lcd-console / display rotation Hannes Petermaier
2015-03-02 21:42 ` Simon Glass
2015-03-03 10:31   ` Hannes Petermaier
2015-03-04 11:58     ` Nikita Kiryanov [this message]
2015-03-02 22:04 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F6F35D.3070005@compulab.co.il \
    --to=nikita@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.