From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YT8KZ-00080r-6K for mharc-qemu-trivial@gnu.org; Wed, 04 Mar 2015 07:23:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8KU-0007nK-3C for qemu-trivial@nongnu.org; Wed, 04 Mar 2015 07:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT8KO-0002a7-GV for qemu-trivial@nongnu.org; Wed, 04 Mar 2015 07:23:10 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:40668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8KI-0002XI-9q; Wed, 04 Mar 2015 07:22:58 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id BD5F640803; Wed, 4 Mar 2015 15:22:49 +0300 (MSK) Message-ID: <54F6F919.9060905@msgid.tls.msk.ru> Date: Wed, 04 Mar 2015 15:22:49 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: "Dr. David Alan Gilbert" References: <1424073025-13262-1-git-send-email-mjt@msgid.tls.msk.ru> <20150304121654.GC2530@work-vm> In-Reply-To: <20150304121654.GC2530@work-vm> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Amit Shah , qemu-devel@nongnu.org, Juan Quintela Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 12:23:13 -0000 04.03.2015 15:16, Dr. David Alan Gilbert wrote: > * Michael Tokarev (mjt@tls.msk.ru) wrote: >> Do not check for rdma->host being empty twice. This removes a large >> "if" block, so code indentation is changed. While at it, remove an >> ugly goto from the loop, replacing it with a cleaner if logic. And >> finally, there's no need to initialize `ret' variable since is always >> has a value. >> >> Signed-off-by: Michael Tokarev > > Juan/Amit: There's a space at the end of a line that got in, so > that just needs fixing in the merge; it's after the 'break;' I already fixed it in my tree two days ago. > but the patch is a big improvement on what's there: > > Reviewed-by: Dr. David Alan Gilbert > > also tested on an RDMA system. Thank you! I think it's okay to merge it using the -trivial tree, I'm about to send a pull request today. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT8KN-0007Ym-Am for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:23:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT8KI-0002YD-Hv for qemu-devel@nongnu.org; Wed, 04 Mar 2015 07:23:03 -0500 Message-ID: <54F6F919.9060905@msgid.tls.msk.ru> Date: Wed, 04 Mar 2015 15:22:49 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1424073025-13262-1-git-send-email-mjt@msgid.tls.msk.ru> <20150304121654.GC2530@work-vm> In-Reply-To: <20150304121654.GC2530@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-trivial@nongnu.org, Amit Shah , qemu-devel@nongnu.org, Juan Quintela 04.03.2015 15:16, Dr. David Alan Gilbert wrote: > * Michael Tokarev (mjt@tls.msk.ru) wrote: >> Do not check for rdma->host being empty twice. This removes a large >> "if" block, so code indentation is changed. While at it, remove an >> ugly goto from the loop, replacing it with a cleaner if logic. And >> finally, there's no need to initialize `ret' variable since is always >> has a value. >> >> Signed-off-by: Michael Tokarev > > Juan/Amit: There's a space at the end of a line that got in, so > that just needs fixing in the merge; it's after the 'break;' I already fixed it in my tree two days ago. > but the patch is a big improvement on what's there: > > Reviewed-by: Dr. David Alan Gilbert > > also tested on an RDMA system. Thank you! I think it's okay to merge it using the -trivial tree, I'm about to send a pull request today. /mjt