From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTA46-0003yC-Om for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:14:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTA42-0005pN-1B for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:14:22 -0500 Message-ID: <54F71336.60806@suse.de> Date: Wed, 04 Mar 2015 15:14:14 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425432686-29851-1-git-send-email-aik@ozlabs.ru> <54F6FA53.5080106@suse.de> In-Reply-To: <54F6FA53.5080106@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add versions to server CPU descriptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org Alex, Am 04.03.2015 um 13:28 schrieb Alexander Graf: > On 04.03.15 02:31, Alexey Kardashevskiy wrote: >> 5b79b1c "target-ppc: Create versionless CPU class per family if KVM" a= dded >> a dynamic CPU class registration with the name of the CPU family which >> QEMU is running on. For example, this allowed specifying "-cpu POWER7" >> on every version of POWER7 machine, not just the one which POWER7 was >> an alias of. I.e. before 5b79b1c, "-cpu POWER7" would not work on real >> POWER7 2.1 and would work on POWER7 2.3 only. The same story for POWER= 8. >> >> However that patch broke POWER5+ support as POWER5+ CPU uses the same >> name as the CPU class so dynamic registering of the POWER5+ class fail= ed. >> >> This redefines POWER5+ server CPUs by adding a version to them and add= ing >> an alias for TCG case. KVM will use dynamically registered CPUs. >> >> While we are here, do the same for 970 CPU. >> >> Signed-off-by: Alexey Kardashevskiy >=20 > Thanks, applied to ppc-next. As Alexey predicted, I object. The 970 part looks good and could be applied immediately if it were a separate patch. But the POWER5+ part I have my doubts about: Was there really a v0.0??? Others start with v1.0 and I have: revision : 2.1 (pvr 003b 0201) Also, this is still just bandaid and not a fix to the code that I pointed out. But let's keep that discussion over at the other patch. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)