From: Eric B Munson <emunson@akamai.com>
To: Josh Hunt <johunt@akamai.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH RESEND] Add element count to hash headers
Date: Wed, 04 Mar 2015 09:39:48 -0500 [thread overview]
Message-ID: <54F71934.6000303@akamai.com> (raw)
In-Reply-To: <54F67D2E.5050003@akamai.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/03/2015 10:34 PM, Josh Hunt wrote:
> On 02/18/2015 01:53 PM, Eric B Munson wrote:
>> snip
>>
>
> Jozsef
>
> Can you clarify what you're looking for when you mentioned (in a
> previous mail) "I don't like any change which affects the userspace
> but not expressed in new set type revision."? Are we breaking ABI
> here by adding a new field to print out the # of elements in a
> hash? Would it be better to default this to off and only print it
> if a new flag were presented?
To be clear, we aren't adding a new field. This field exists already
and is not in use for hash sets.
>
> I guess I don't see why we should rev all of the hash types for
> this change when we're not really adding any functionality to them.
> We can rev the ver of the library to signify a change here. Would
> that help?
>
> If we do need to add a new revision I think we may want to step
> back and make sure there's no other information we want to expose
> first and if there is do it all in one shot to minimize the # of
> revisions.
>
> Thanks for your help. Josh
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBAgAGBQJU9xkuAAoJELbVsDOpoOa9eFgP/1FEhgQw/zrHxVhsPTi1uYRz
h1ftmpOgkgqJWEBsGoydOr+hbYATIgoU6O829jH84OKFQdoPCl00uqO7XXLB601C
ii1OPxb57iHL9/FnbTAHuSKqBhzQPwUSWuICISLulgAMD25an5eckbnRR/i8h0SW
kEbDitCBFRqyKRJZXSSS36oQuryd9j/pH2UYxE5vtQ9oiTW+MXxK7HvzDE6RTssz
rpVW3lbPXnLucMt4te1V4iX7t7r0f7UVcQuQGSOSEm1jB+94+AIowaoUzJDNkC6E
JMMERSOS9RI7LerlG+5iy13nFQgOcTwxX/Xfhy5CNl7v7w6biVzzS18Kf2qwdFmt
yOM/InBpwecE8VoTM2tlP6WLqpsNEE/aaiA7vLiqKU+U7xSYBN6o+8w0FdpKtasx
+TNqr7wfKBx/oyvZQSb13YQ89ci/gDeVczO51peoNhQn9zy+XY41DSLrdCPfa9HZ
x1lkiazFP/x07WpHPKs+g4AuMNkQ0vTkowVkH3orcBRnqUxinngAsnkefXC1TZ96
L38bJXLkOC//YfE+i/RtzzuX5KN6rbiw//h5nM3m0bg6Ri7royZuAtgt2ZoYDM0m
SmxD1bX7lqi46G4FvPMDCzD/NlelMNJkNWAlvsWFx1K5TC4jXQhDMIjDv9Mpz2PT
vI1LkbGQ2JYLUGBNmTzz
=pny3
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-03-04 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 19:53 [PATCH RESEND] Add element count to hash headers Eric B Munson
2015-03-04 3:34 ` Josh Hunt
2015-03-04 14:39 ` Eric B Munson [this message]
2015-03-06 21:45 ` Jozsef Kadlecsik
2015-03-09 19:05 ` Eric B Munson
2015-03-11 19:20 ` Jozsef Kadlecsik
2015-03-19 17:38 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F71934.6000303@akamai.com \
--to=emunson@akamai.com \
--cc=johunt@akamai.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.