From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id E008BE00718; Wed, 4 Mar 2015 07:58:17 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.170 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E6EA8E006E9 for ; Wed, 4 Mar 2015 07:58:12 -0800 (PST) Received: by wivr20 with SMTP id r20so78469wiv.5 for ; Wed, 04 Mar 2015 07:58:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=VufiBtY8GlS3aWRXV5ML7Bak+pGte8KFkST0ZlNPHJU=; b=XHj+VJEBd5rUZGfr/qcI0AizC/bekk2lq+xgX/ME0+IpTAbjW2s8vln6CUscm90EVC e7z6C+7DM6m192DVMtl3igv1QN03LNdgDdP3JV9UqEs3tH88OiUGMcTi/Ii7JINWLJIF ZVTF4kyxUavZgVOu2ZUhaavm6ONU4UCW4bP7VnDeu4r0jcAnDhW2lqo5OzK/3GOMWute GJEJbrALueJU25YYgL6iOZaWKiCp0SB383NYwk01y5wtDLhJUsmT5R/zIS8XmFI2ALH2 7P2YjXP0KR66N1wX0hiFe3IPyRVsuhqKzT7KGxSRcNWcH/C4D8wwsRxh9ZYQZQm0M0v0 Ab7Q== X-Gm-Message-State: ALoCoQmSV51VgWrJ83xoTPNDdDs61nYhcEWru47s3fF6huE6f2R/x70KwFeB784P8FyyhbOPUtMb X-Received: by 10.194.142.205 with SMTP id ry13mr9408898wjb.73.1425484691932; Wed, 04 Mar 2015 07:58:11 -0800 (PST) Received: from [192.168.2.86] ([83.217.123.106]) by mx.google.com with ESMTPSA id yr10sm3740688wjc.0.2015.03.04.07.58.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 07:58:11 -0800 (PST) Message-ID: <54F72B92.9050105@intel.com> Date: Wed, 04 Mar 2015 15:58:10 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "Lerner, David M (Wind River)" , "Damian, Alexandru" References: <011977994B5AE74ABA2BD08E983BAAABBC6BC536@ALA-MBA.corp.ad.wrs.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] 7191 Version2 format shaid on all layers page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 15:58:18 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Hi Dave, Only one thing, we have renamed the branch column to "reference" because the database confusingly splits up the vcs reference into, branch, commit, upstream branch etc etc We have abstracted trying to work out which to display via the function "get_vcs_reference" So if you switch + {% if o.branch|is_shaid %} to + {% if o.get_vcs_reference|is_shaid %} and you can then also remove the check to see if which kind of reference to display + {% else %} + {{o.up_branch.name}} It's a bit confusing so if you'd like me just to push a patch on top then you can squash it into yours. Michael On 04/03/15 12:26, Barros Pena, Belen wrote: > On 03/03/2015 22:56, "Lerner, Dave" wrote: > >> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layer >> s_commitfield_7191 >> >> 7191 - If field looks like a commit SHAID(hex and 40 digits), truncate >> field as button label, and show full SHAID when button depressed. > This seems to be working for me. > > Thanks! > > Belén > >> Dave Lerner >>