From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests Date: Wed, 4 Mar 2015 16:53:39 +0000 Message-ID: <54F73893.2060805@citrix.com> References: <1425036812-23536-1-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YTCZj-0006op-FK for xen-devel@lists.xenproject.org; Wed, 04 Mar 2015 16:55:11 +0000 In-Reply-To: <1425036812-23536-1-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Yang Zhang , Kevin Tian , Aravind Gopalakrishnan , Jan Beulich , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On 27/02/15 11:33, Roger Pau Monne wrote: > iommu_share_p2m_table should not prevent PVH guests from using a shared page > table between the IOMMU and EPT. Clean the code by removing the asserts in > the vendor specific implementations (amd_iommu_share_p2m, iommu_set_pgd), > and moving the hap_enabled assert to the caller (iommu_share_p2m_table). > > Also fix another incorrect usage of is_hvm_domain usage in > arch_iommu_populate_page_table. This has not given problems so far because > all the pages in PVH guests are of type PGT_writable_page. dom0 PVH failed to boot on my test system without this patch so: Tested-by: David Vrabel Thanks. David