From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1YTGXa-0000Ec-Ba
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 16:09:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1YTGXT-0000Yb-D7
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 16:09:14 -0500
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:44170)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1YTGXT-0000YG-6q
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 16:09:07 -0500
Message-ID: <54F7746D.2060107@weilnetz.de>
Date: Wed, 04 Mar 2015 22:09:01 +0100
From: Stefan Weil <stefan.weil@weilnetz.de>
MIME-Version: 1.0
References: <1425396538-16765-1-git-send-email-imammedo@redhat.com>
In-Reply-To: <1425396538-16765-1-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] advance minimum required GLib version to
 2.22
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com

Am 03.03.2015 um 16:28 schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>   configure | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index 7ba4bcb..db79e0a 100755
> --- a/configure
> +++ b/configure
> @@ -2744,12 +2744,7 @@ fi
>   ##########################################
>   # glib support probe
>   
> -if test "$mingw32" = yes; then
> -    # g_poll is required in order to integrate with the glib main loop.
> -    glib_req_ver=2.20
> -else
> -    glib_req_ver=2.12
> -fi
> +glib_req_ver=2.22
>   glib_modules=gthread-2.0
>   if test "$modules" = yes; then
>       glib_modules="$glib_modules gmodule-2.0"

A comment in the commit message (or even in file configure) why 2.22 is 
needed would be helpful (this applies also to other requirements).

I typically face the problem that I want to run a build test on a 
platform which does not support the latest package versions (e. g. 
Debian stable or Windows). Then I usually try to lower the requirements 
until the feature which depends on that requirement is enabled. 
Especially for glib the requirements for Linux, Mac and Windows might 
also differ.

Regards
Stefan