Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Simplify if condition

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/04/15 18:32, Ksenija Stanojevic wrote:
> This patch simplifies if condition using following Coccinelle script:
> @@ bool a; symbol true; @@
> (
> - a != true
> + !a
> |
> - a == true
> + a
> )
> @@ bool a; symbol false; @@
> (
> - a != false
> + a
> |
> - a == false
> + !a
> )
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The patch is correct, however you should write a proper commit message
rather than just relying on the coccinelle script.

It's important to try and show in a commit message that you know why you
made the changes, and not just comply with an automated tool.

Cheers,
Jes


> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index b5a26f3..8359705 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -335,7 +335,7 @@ static int r8192_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
>  	if (!priv->up)
>  		return -ENETDOWN;
>  
> -	if (priv->ieee80211->LinkDetectInfo.bBusyTraffic == true)
> +	if (priv->ieee80211->LinkDetectInfo.bBusyTraffic)
>  		return -EAGAIN;
>  	if (wrqu->data.flags & IW_SCAN_THIS_ESSID) {
>  		struct iw_scan_req *req = (struct iw_scan_req *)b;
>