All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kazutomo Yoshii <kazutomo.yoshii@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] mm: fix do_mbind return value
Date: Wed, 04 Mar 2015 20:20:04 -0600	[thread overview]
Message-ID: <54F7BD54.5060502@gmail.com> (raw)

I noticed that numa_alloc_onnode() failed to allocate memory on a
specified node in v4.0-rc1. I added a code to check the return value
of walk_page_range() in queue_pages_range() so that do_mbind() only
returns an error number or zero.

Signed-off-by: Kazutomo Yoshii <kazutomo.yoshii@gmail.com>
---
 mm/mempolicy.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 4721046..ea79171 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -644,6 +644,7 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
 		.nmask = nodes,
 		.prev = NULL,
 	};
+	int err;
 	struct mm_walk queue_pages_walk = {
 		.hugetlb_entry = queue_pages_hugetlb,
 		.pmd_entry = queue_pages_pte_range,
@@ -652,7 +653,10 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
 		.private = &qp,
 	};
 -	return walk_page_range(start, end, &queue_pages_walk);
+	err = walk_page_range(start, end, &queue_pages_walk);
+	if (err < 0)
+		return err;
+	return 0;
 }
  /*
-- 
1.8.3.1


             reply	other threads:[~2015-03-05  2:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  2:20 Kazutomo Yoshii [this message]
2015-03-05  6:53 ` [PATCH] mm: fix do_mbind return value David Rientjes
2015-03-05  7:44   ` Kazutomo Yoshii
2015-03-05  8:02   ` [PATCH] mm: pagewalk: prevent positive return value of walk_page_test() from being passed to callers (Re: [PATCH] mm: fix do_mbind return value) Naoya Horiguchi
2015-03-05  8:02     ` Naoya Horiguchi
2015-03-05  8:09     ` Naoya Horiguchi
2015-03-05  8:09       ` Naoya Horiguchi
2015-03-05  8:27       ` Naoya Horiguchi
2015-03-05  8:27         ` Naoya Horiguchi
2015-03-05 20:34     ` David Rientjes
2015-03-05 20:34       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F7BD54.5060502@gmail.com \
    --to=kazutomo.yoshii@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.