All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <mchristi@redhat.com>
To: Mel Gorman <mgorman@suse.de>, Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Sage Weil <sage@redhat.com>, NeilBrown <neilb@suse.de>,
	netdev@vger.kernel.org
Subject: Re: SOCK_MEMALLOC vs loopback
Date: Wed, 04 Mar 2015 22:13:30 -0600	[thread overview]
Message-ID: <54F7D7EA.6010303@redhat.com> (raw)
In-Reply-To: <54F7D5A7.1060404@redhat.com>

On 03/04/2015 10:03 PM, Mike Christie wrote:
> On 03/04/2015 02:04 PM, Mel Gorman wrote:
>> > On Wed, Mar 04, 2015 at 09:38:48PM +0300, Ilya Dryomov wrote:
>>> >> Hello,
>>> >>
>>> >> A short while ago Mike added a patch to libceph to set SOCK_MEMALLOC on
>>> >> libceph sockets and PF_MEMALLOC around send/receive paths (commit
>>> >> 89baaa570ab0, "libceph: use memalloc flags for net IO").  rbd is much
>>> >> like nbd and is succeptible to all the same memory allocation
>>> >> deadlocks, so it seemed like a step in the right direction.
>>> >>
>> > 
>> > The contract for SOCK_MEMALLOC is that it would only be used for temporary
>> > allocations that were necessary for the system to make forward progress. In
>> > the case of swap-over-NFS, it would only be used for transmitting
>> > buffers that were necessary to write data to swap when there were no
> Are upper layers like NFS/iSCSI/NBD/RBD supposed to know or track when
> there are no other options (for example if a GFP_ATOMIC allocation
> fails, then set the flags and retry the operation), or are they supposed
> to be able to set the flags, send IO and let the network layer handle it?
> 

Oh yeah, maybe I misunderstood you. Were you just saying we should not
be using it for the configuration we are hitting the problem on?

  reply	other threads:[~2015-03-05  4:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 18:38 SOCK_MEMALLOC vs loopback Ilya Dryomov
2015-03-04 20:04 ` Mel Gorman
2015-03-05  4:03   ` Mike Christie
2015-03-05  4:13     ` Mike Christie [this message]
2015-03-05  7:09       ` Ilya Dryomov
2015-03-05  9:50     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F7D7EA.6010303@redhat.com \
    --to=mchristi@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=idryomov@gmail.com \
    --cc=mgorman@suse.de \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=sage@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.