From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Thu, 05 Mar 2015 10:33:14 +0000 Subject: Re: [PATCH 0/5] UBI: Coverity-inspired fixes Message-Id: <54F830EA.4080106@nod.at> List-Id: References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Brian Norris , Artem Bityutskiy Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Brian, Am 28.02.2015 um 11:23 schrieb Brian Norris: > Except for the last one, these were inspired by Coverity Scan results. > > These fixes have barely been tested, but they are pretty straightforward > logically. As they've been sitting in my dust pile too long, I thought I'd at > least get them out there. > > Brian Norris (5): > UBI: account for bitflips in both the VID header and data > UBI: fix out of bounds write > UBI: initialize LEB number variable > UBI: fix check for "too many bytes" > UBI: align comment for readability Nice work! I'll test them later today. Just a quick question, no patch has a stable tag, is this by design? >From a first look most of them look like stable material. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YTT67-0006Y4-0U for linux-mtd@lists.infradead.org; Thu, 05 Mar 2015 10:33:44 +0000 Message-ID: <54F830EA.4080106@nod.at> Date: Thu, 05 Mar 2015 11:33:14 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Brian Norris , Artem Bityutskiy Subject: Re: [PATCH 0/5] UBI: Coverity-inspired fixes References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Brian, Am 28.02.2015 um 11:23 schrieb Brian Norris: > Except for the last one, these were inspired by Coverity Scan results. > > These fixes have barely been tested, but they are pretty straightforward > logically. As they've been sitting in my dust pile too long, I thought I'd at > least get them out there. > > Brian Norris (5): > UBI: account for bitflips in both the VID header and data > UBI: fix out of bounds write > UBI: initialize LEB number variable > UBI: fix check for "too many bytes" > UBI: align comment for readability Nice work! I'll test them later today. Just a quick question, no patch has a stable tag, is this by design? >>From a first look most of them look like stable material. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754964AbbCEKdX (ORCPT ); Thu, 5 Mar 2015 05:33:23 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754907AbbCEKdS (ORCPT ); Thu, 5 Mar 2015 05:33:18 -0500 Message-ID: <54F830EA.4080106@nod.at> Date: Thu, 05 Mar 2015 11:33:14 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Brian Norris , Artem Bityutskiy CC: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/5] UBI: Coverity-inspired fixes References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian, Am 28.02.2015 um 11:23 schrieb Brian Norris: > Except for the last one, these were inspired by Coverity Scan results. > > These fixes have barely been tested, but they are pretty straightforward > logically. As they've been sitting in my dust pile too long, I thought I'd at > least get them out there. > > Brian Norris (5): > UBI: account for bitflips in both the VID header and data > UBI: fix out of bounds write > UBI: initialize LEB number variable > UBI: fix check for "too many bytes" > UBI: align comment for readability Nice work! I'll test them later today. Just a quick question, no patch has a stable tag, is this by design? >>From a first look most of them look like stable material. Thanks, //richard