From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.
Date: Thu, 05 Mar 2015 07:57:45 -0500 [thread overview]
Message-ID: <54F852C9.1010407@canonical.com> (raw)
In-Reply-To: <CAGdLNWEb0yx4Fum8mMnivChFU8NsKkk9RtwmAd1kgQiZSBjk5A@mail.gmail.com>
On 03/04/2015 07:05 PM, Azael Avalos wrote:
> Hi there,
>
> 2015-03-04 14:52 GMT-07:00 Joseph Salisbury <joseph.salisbury@canonical.com>:
> ...
>> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } },
>> + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } },
> ...
>
> These two are not neccesary, as they may collide with "previous song"
> and "playpause" in case Toshiba (or its manufacturers) decide to use
> those keys.
>
> If you can, please test the first two patches from the gmane archive [1],
> they eliminate the need of the DMI matching list. And it would be great
> to have more laptops tested.
>
> [1] http://comments.gmane.org/gmane.linux.drivers.platform.x86.devel/6602
>
>
> Cheers
> Azael
>
>
Thanks for the feedback, Azael. I'll spin up a kernel with the first
two patches in that archive, and have them testing. I'll reply with the
results.
Thanks again,
Joe
next prev parent reply other threads:[~2015-03-05 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:52 [PATCH 1/2] toshiba_acpi: Add Satellite L845 to alternative keymap Joseph Salisbury
2015-03-04 21:52 ` [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings Joseph Salisbury
2015-03-05 0:05 ` Azael Avalos
2015-03-05 12:57 ` Joseph Salisbury [this message]
2015-03-05 20:59 ` Joseph Salisbury
2015-03-05 21:04 ` Azael Avalos
2015-03-05 21:06 ` Joseph Salisbury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F852C9.1010407@canonical.com \
--to=joseph.salisbury@canonical.com \
--cc=coproscefalo@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.