From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 05 Mar 2015 14:11:07 +0100 (CET) Received: from cantor2.suse.de ([195.135.220.15]:37784 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007189AbbCENLFalUy2 (ORCPT ); Thu, 5 Mar 2015 14:11:05 +0100 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E8FE3AC2B; Thu, 5 Mar 2015 13:11:02 +0000 (UTC) Message-ID: <54F855E4.9030106@suse.de> Date: Thu, 05 Mar 2015 14:11:00 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Valentin Rothberg , akpm@linux-foundation.org CC: Jonathan Corbet , Ralf Baechle , David Woodhouse , Brian Norris , Greg Kroah-Hartman , Paul Bolle , Jiri Kosina , Ewan Milne , Christoph Hellwig , Huacai Chen , Hongliang Tao , Nishanth Menon , Santosh Shilimkar , Peter Ujfalusi , Tony Lindgren , Rajendra Nayak , Sricharan R , Afzal Mohammed , Keerthy , Dan Carpenter , Zhou Wang , Felipe Balbi , Laurent Pinchart , Thomas Gleixner , Randy Dunlap , Kukjin Kim , "Rafael J. Wysocki" , Quentin Lambert , Eyal Perry , Arnd Bergmann , Peter Zijlstra , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, iss_storagedev@hp.com, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 46201 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: hare@suse.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 03/05/2015 01:59 PM, Valentin Rothberg wrote: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg > --- > The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely > as IRQF_DISABLED is gone now; the usage in older kernel versions > (including the old SA_INTERRUPT flag) should be discouraged. The > trouble of using IRQF_SHARED is a general problem and not specific to > any driver. > > I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since > it has already been removed in linux-next by commit b0e1ee8e1405 > ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED"). > > All remaining references are changelogs that I suggest to keep. While you're at it: having '0x0' as a value for the irq flags looks a bit silly, and makes you wonder what the parameter is for. I would rather like to have #define IRQF_NONE 0x0 and use it for these cases. That way the scope of that parameter is clear. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cantor2.suse.de ([195.135.220.15] helo=mx2.suse.de) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YTVYo-0002K5-K3 for linux-mtd@lists.infradead.org; Thu, 05 Mar 2015 13:11:31 +0000 Message-ID: <54F855E4.9030106@suse.de> Date: Thu, 05 Mar 2015 14:11:00 +0100 From: Hannes Reinecke MIME-Version: 1.0 To: Valentin Rothberg , akpm@linux-foundation.org Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: Nishanth Menon , linux-mips@linux-mips.org, Quentin Lambert , Jiri Kosina , Tony Lindgren , Peter Ujfalusi , Sricharan R , linux-mtd@lists.infradead.org, Ralf Baechle , Huacai Chen , Christoph Hellwig , Kukjin Kim , iss_storagedev@hp.com, Jonathan Corbet , "Rafael J. Wysocki" , Ewan Milne , Peter Zijlstra , Dan Carpenter , Afzal Mohammed , Arnd Bergmann , Rajendra Nayak , Eyal Perry , Thomas Gleixner , Paul Bolle , Keerthy , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi , Zhou Wang , linux-usb@vger.kernel.org, Santosh Shilimkar , Greg Kroah-Hartman , Hongliang Tao , Brian Norris , David Woodhouse , Laurent Pinchart List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/05/2015 01:59 PM, Valentin Rothberg wrote: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg > --- > The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely > as IRQF_DISABLED is gone now; the usage in older kernel versions > (including the old SA_INTERRUPT flag) should be discouraged. The > trouble of using IRQF_SHARED is a general problem and not specific to > any driver. > > I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since > it has already been removed in linux-next by commit b0e1ee8e1405 > ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED"). > > All remaining references are changelogs that I suggest to keep. While you're at it: having '0x0' as a value for the irq flags looks a bit silly, and makes you wonder what the parameter is for. I would rather like to have #define IRQF_NONE 0x0 and use it for these cases. That way the scope of that parameter is clear. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)