From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4DC80E008CF; Thu, 5 Mar 2015 05:34:50 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (scerveau[at]gmail.com) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.47 listed in list.dnswl.org] Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0D11FE008CF for ; Thu, 5 Mar 2015 05:34:38 -0800 (PST) Received: by wggy19 with SMTP id y19so53404082wgg.10 for ; Thu, 05 Mar 2015 05:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=x3xawthlxcagb39iMdz/z2K1S09ZAbq0Dp5G13kJtQ8=; b=YpNxJjEKO7mmXyo1CIt3BphsJbjwp9RvSkWw41C0+ik6LPXeP6iUbq3TD33FXQRtqi 81+yF6Df618HuN1zBPKRqyB/FiTQq85ipBMz94HbYiYx1VSnJT+0SqA0SnilZtp8nFxC 7/NFKn9Lc1TtyrjQjN20gZiiW6asSaRkxqcwfptFHatpmmKRfZhad/0holJv/soEOWwf n81z0CPeaaWxVoxplT6oqJEb2v9/UGVyGscwZ5ArET2sQ4IYxx+MZmQvPZtAvvJUhM+G iqEqIcC2MO8rbMGeGAFsngmL1pBmn7li2u1GJyM3bcCq6Eywupk22+XJuE6io5NYWGmH EzTg== X-Received: by 10.194.94.1 with SMTP id cy1mr17961049wjb.127.1425562478070; Thu, 05 Mar 2015 05:34:38 -0800 (PST) Received: from [172.24.63.26] (connected-labs-gw1.ter2.neodc.mpl.cust.as8218.eu. [94.103.137.126]) by mx.google.com with ESMTPSA id a13sm10551990wjx.30.2015.03.05.05.34.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 05:34:36 -0800 (PST) Message-ID: <54F85B6B.70901@gmail.com> Date: Thu, 05 Mar 2015 14:34:35 +0100 From: scerveau User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Carlos Rafael Giani , meta-freescale@yoctoproject.org References: <54F58945.3070609@gmail.com> <54F5B28C.2010709@pseudoterminal.org> <54F827ED.4040600@gmail.com> <54F8358E.4000405@pseudoterminal.org> In-Reply-To: <54F8358E.4000405@pseudoterminal.org> Subject: Re: GstVolume with dizzy is not working when changing to a value inferior to 1 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 13:34:50 -0000 X-Groupsio-MsgNum: 13035 Content-Type: multipart/mixed; boundary="------------050201090405080903050608" --------------050201090405080903050608 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Dear all, Here is the patch who can be merged in meta-freescale concerning gstvolume.c in gstreamer1.0-plugins-base I guess this patch should be merged in poky and not in meta-freescale seen that the bug is also on raspberry pi 2 by example. A bug entry has been submitted to gcc bug tracker system: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65325 Best regards. Stéphane On 03/05/2015 11:53 AM, Carlos Rafael Giani wrote: > Yes, indeed. -O2 with gcc 4.9 seems to break Orc. > > Please mention this in the GStreamer mailing list. > > Or, better yet, in their bugzilla: > https://bugzilla.gnome.org/page.cgi?id=browse.html&product=GStreamer > The bugreport should go to "gst-plugins-base". Or perhaps also to "orc". > > On 03/05/2015 10:54 AM, scerveau wrote: >> Dear all, >> >> I had a try on rpi2 and i'm facing the same issue. >> The sound is not working when we change the volume value to less than >> 1.0 >> Looks like a compiler issue in gcc-4.9 on arm7 ? >> My fix for now is disabling gstreamer1.0-plugins-base optimization >> byt putting CFLAGS to -O0 >> >> Best regards. >> >> Stéphane >> >> On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote: >>> On 03/03/2015 01:20 PM, Otavio Salvador wrote: >>>> Hello Stephane, >>>> >>>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau wrote: >>>>> Dear all, >>>>> >>>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The >>>>> volume >>>>> element is not working properly. >>>>> Whith this pipeline: >>>>> >>>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink >>>>> >>>>> The sound level is equal to 0 instead of half of the standard >>>>> volume. If i >>>>> put volume=1 this is working properly. >>>>> Affter investigation i understood that it is related to this line >>>>> >>>>> gstvolume.c:251 self->current_volume = volume; in >>>>> volume_update_volume >>>>> >>>>> If i put any log just after this line, the behaviour is coming >>>>> back to >>>>> normal. If i compile with -00 its also working fine. >>>>> >>>>> CFLAGS += " -O0" >>>>> >>>>> That's my fix for now ;) >>>>> >>>>> Please advise on how to fix this issue because i dont know if its >>>>> related to >>>>> the compiler (4.9.1) or to gstreamer. >>>> Added Khem in Cc. Khem how we can gather info to see what's going on? >>>> >>> >>> I saw this before. It is a strange error. I did a hexdump of the >>> input and output samples to see what's going on. Input samples are >>> nonzero, as expected. Output samples however, are all nullbytes. >>> Sample rate, number of channels, sample format are all irrelevant - >>> it occurs with them all. >>> >>> This could be a compiler bug, an error in Orc, or both, especially >>> since -O0 fixes it. >>> >>> Carlos >> > --------------050201090405080903050608 Content-Type: text/x-patch; name="volume_explicitely_cast_integers_to_double.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="volume_explicitely_cast_integers_to_double.patch" diff --git a/gst/volume/gstvolume.c b/gst/volume/gstvolume.c index 0f5b362..94d03a3 100644 --- a/gst/volume/gstvolume.c +++ b/gst/volume/gstvolume.c @@ -250,10 +250,14 @@ volume_update_volume (GstVolume * self, const GstAudioInfo * info, self->current_mute = FALSE; self->current_volume = volume; - self->current_vol_i8 = volume * VOLUME_UNITY_INT8; - self->current_vol_i16 = volume * VOLUME_UNITY_INT16; - self->current_vol_i24 = volume * VOLUME_UNITY_INT24; - self->current_vol_i32 = volume * VOLUME_UNITY_INT32; + self->current_vol_i8 = + (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT8); + self->current_vol_i16 = + (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT16); + self->current_vol_i24 = + (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT24); + self->current_vol_i32 = + (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT32); passthrough = (self->current_vol_i16 == VOLUME_UNITY_INT16); } --------------050201090405080903050608--