From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTW7P-0007xO-8E for qemu-devel@nongnu.org; Thu, 05 Mar 2015 08:47:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTW7J-0005LM-SH for qemu-devel@nongnu.org; Thu, 05 Mar 2015 08:47:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTW7J-0005Ko-L7 for qemu-devel@nongnu.org; Thu, 05 Mar 2015 08:47:09 -0500 Message-ID: <54F85E47.9030005@redhat.com> Date: Thu, 05 Mar 2015 14:46:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> <1425435224-2630-3-git-send-email-ehabkost@redhat.com> <20150305134345.GE13041@thinpad.lan.raisama.net> In-Reply-To: <20150305134345.GE13041@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Gu Zheng , Igor Mammedov , Riku Voipio , =?windows-1252?Q?Andreas_F=E4rber?= , Peter Maydell On 05/03/2015 14:43, Eduardo Habkost wrote: > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: >> The existing apic_id = cpu_index code has no visible effect: the PC code >> already initializes the APIC ID according to the topology on >> pc_new_cpu(), and linux-user memcpy()s the CPU state (including >> cpuid_apic_id) on cpu_copy(). >> >> Remove the dead code and simply let APIC ID to to be 0 by default. This >> doesn't change behavior of PC because apic-id is already explicitly set, >> and doesn't affect linux-user because APIC ID was already always 0. >> >> Signed-off-by: Eduardo Habkost > > This patch is holding the rest of the series, so a Reviewed-by or > Acked-by would be welcome. > > This change removes the 254-CPU limit from {i386,x86_64}-linux-user that > Peter and I discussed previously. Reviewed-by: Paolo Bonzini > >> --- >> target-i386/cpu.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index 8fc5727..05cac57 100644 >> --- a/target-i386/cpu.c >> +++ b/target-i386/cpu.c >> @@ -2923,7 +2923,6 @@ static void x86_cpu_initfn(Object *obj) >> NULL, NULL, (void *)cpu->filtered_features, NULL); >> >> cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY; >> - env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index); >> >> x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); >> >> -- >> 2.1.0 >> >> >