From: Peter Hurley <peter@hurleysoftware.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>, Samuel Ortiz <samuel@sortiz.org>,
"David S. Miller" <davem@davemloft.net>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-serial@vger.kernel.org, netdev@vger.kernel.org,
ZIV-Asier Llano Palacios <asier.llano@cgglobal.com>
Subject: Re: [PATCH 5/5] TTY: fix tty_wait_until_sent maximum timeout
Date: Thu, 05 Mar 2015 09:32:25 -0500 [thread overview]
Message-ID: <54F868F9.1050804@hurleysoftware.com> (raw)
In-Reply-To: <1425461947-15888-6-git-send-email-johan@kernel.org>
On 03/04/2015 04:39 AM, Johan Hovold wrote:
> Currently tty_wait_until_sent may take up to twice as long as the
> requested timeout while waiting for driver and hardware buffers to
> drain.
>
> Fix this by taking the remaining number of jiffies after waiting for
> driver buffers to drain into account so that the timeout actually
> becomes a maximum timeout as it is documented to be.
>
> Note that this specifically implies tighter timings when closing a port
> as a consequence of actually honouring the port closing-wait setting
> for drivers relying on tty_wait_until_sent_from_close (e.g. via
> tty_port_close_start).
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
next prev parent reply other threads:[~2015-03-05 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 9:39 [PATCH 0/5] TTY: fix tty_wait_until_sent on 64-bit machines Johan Hovold
2015-03-04 9:39 ` [PATCH 1/5] net: irda: fix wait_until_sent poll timeout Johan Hovold
2015-03-04 9:39 ` [PATCH 2/5] TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation Johan Hovold
2015-03-05 14:33 ` Peter Hurley
2015-03-04 9:39 ` [PATCH 3/5] USB: serial: fix infinite wait_until_sent timeout Johan Hovold
2015-03-04 9:39 ` [PATCH 4/5] TTY: fix tty_wait_until_sent on 64-bit machines Johan Hovold
2015-03-05 14:31 ` Peter Hurley
2015-03-04 9:39 ` [PATCH 5/5] TTY: fix tty_wait_until_sent maximum timeout Johan Hovold
2015-03-05 14:32 ` Peter Hurley [this message]
2015-03-07 2:43 ` [PATCH 0/5] TTY: fix tty_wait_until_sent on 64-bit machines Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F868F9.1050804@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=alan@linux.intel.com \
--cc=asier.llano@cgglobal.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.