From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTacH-0000CZ-Cy for qemu-devel@nongnu.org; Thu, 05 Mar 2015 13:35:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTacC-0003fv-Do for qemu-devel@nongnu.org; Thu, 05 Mar 2015 13:35:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59691 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTacC-0003fk-0A for qemu-devel@nongnu.org; Thu, 05 Mar 2015 13:35:20 -0500 Message-ID: <54F8A1E5.6000407@suse.de> Date: Thu, 05 Mar 2015 19:35:17 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> <1425435224-2630-3-git-send-email-ehabkost@redhat.com> <20150305134345.GE13041@thinpad.lan.raisama.net> In-Reply-To: <20150305134345.GE13041@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Gu Zheng , Peter Maydell , Igor Mammedov , Riku Voipio , Paolo Bonzini Am 05.03.2015 um 14:43 schrieb Eduardo Habkost: > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: >> The existing apic_id =3D cpu_index code has no visible effect: the PC = code >> already initializes the APIC ID according to the topology on >> pc_new_cpu(), and linux-user memcpy()s the CPU state (including >> cpuid_apic_id) on cpu_copy(). >> >> Remove the dead code and simply let APIC ID to to be 0 by default. Thi= s >> doesn't change behavior of PC because apic-id is already explicitly se= t, >> and doesn't affect linux-user because APIC ID was already always 0. >> >> Signed-off-by: Eduardo Habkost >=20 > This patch is holding the rest of the series, so a Reviewed-by or > Acked-by would be welcome. >=20 > This change removes the 254-CPU limit from {i386,x86_64}-linux-user tha= t > Peter and I discussed previously. Reviewed-by: Andreas F=E4rber Are you going to send a new pull for the 2 plus these 5 now? Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)