From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Michal Sekletar <msekleta@redhat.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jpirko@redhat.com>,
guy@alum.mit.edu, atzm@stratosphere.co.jp
Subject: Re: [PATCH] filter: introduce SKF_AD_VLAN_PROTO BPF extension
Date: Thu, 05 Mar 2015 12:40:42 -0800 [thread overview]
Message-ID: <54F8BF4A.3090702@plumgrid.com> (raw)
In-Reply-To: <54F8B680.4050307@iogearbox.net>
On 3/5/15 12:03 PM, Daniel Borkmann wrote:
> On 03/05/2015 05:52 PM, Alexei Starovoitov wrote:
>> imo there is a benefit of giving programs more visibility into
>> skb metadata.
>
> I'm not really a big fan of it, but given we added commit a0cdfcf39362
> ("packet: deliver VLAN TPID to userspace") to packet sockets ...
good point, since skb->vlan_proto is already exposed to user space
via that commit, it makes sense to let bpf see it as well.
For consistency with tpacket, I'd call it SKF_AD_VLAN_TPID
next prev parent reply other threads:[~2015-03-05 20:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 20:41 [PATCH] filter: introduce SKF_AD_VLAN_PROTO BPF extension Michal Sekletar
2015-03-04 21:03 ` Alexei Starovoitov
2015-03-04 21:14 ` Guy Harris
2015-03-04 23:47 ` Alexei Starovoitov
2015-03-05 6:50 ` Jiri Pirko
2015-03-05 7:23 ` Alexei Starovoitov
2015-03-05 7:24 ` Michal Kubecek
2015-03-05 7:49 ` Alexei Starovoitov
2015-03-05 8:35 ` Guy Harris
2015-03-05 9:23 ` Michal Kubecek
2015-03-05 2:28 ` Toshiaki Makita
2015-03-05 2:41 ` Alexei Starovoitov
2015-03-05 10:37 ` Michal Sekletar
2015-03-05 16:52 ` Alexei Starovoitov
2015-03-05 20:03 ` Daniel Borkmann
2015-03-05 20:40 ` Alexei Starovoitov [this message]
2015-03-06 8:09 ` Michal Sekletar
2015-03-06 9:04 ` Michal Sekletar
2015-03-06 17:23 ` Daniel Borkmann
2015-03-06 14:02 ` Michal Kubecek
2015-03-06 17:54 ` Daniel Borkmann
2015-03-05 8:52 ` Jiri Pirko
2015-03-05 8:57 ` Denis Kirjanov
2015-03-05 14:33 ` Michal Sekletar
2015-03-05 18:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F8BF4A.3090702@plumgrid.com \
--to=ast@plumgrid.com \
--cc=atzm@stratosphere.co.jp \
--cc=daniel@iogearbox.net \
--cc=guy@alum.mit.edu \
--cc=jpirko@redhat.com \
--cc=msekleta@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.