From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] test_x86_emulate: fix inline assembly in
	blowfish code
Date: Fri, 06 Mar 2015 11:46:57 +0000
Message-ID: <54F993B1.8050204@citrix.com>
References: <54F99E030200007800066F8F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <amc96@hermes.cam.ac.uk>) id 1YTqiX-0000nc-Un
	for xen-devel@lists.xenproject.org; Fri, 06 Mar 2015 11:46:58 +0000
In-Reply-To: <54F99E030200007800066F8F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Euan Harris <euan.harris@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/03/2015 11:30, Jan Beulich wrote:
> With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't
> optimize debug builds; add macro debugging information") results in the
> file scope inline assembly no longer being emitted to the .text section
> without explicitly switching to it, which causes the blowfish test to
> signal SEGV.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/tools/tests/x86_emulator/blowfish.c
> +++ b/tools/tests/x86_emulator/blowfish.c
> @@ -21,7 +21,8 @@ Foundation, Inc., 59 Temple Place, Suite
>  uint64_t blowfish_test(uint64_t input);
>  
>  asm (
> -    ".globl _start\n"
> +    "\t.text\n"
> +    "\t.globl _start\n"
>      "_start:\n"
>  #if defined(__i386__)
>      "push %edx; push %eax; "
>
>
>