From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTuwa-00047a-BB for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:17:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTuwX-0001Yx-GY for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:17:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTuwX-0001YX-8e for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:17:41 -0500 Message-ID: <54F9D31E.505@redhat.com> Date: Fri, 06 Mar 2015 09:17:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425478176-12044-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425478176-12044-4-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1425478176-12044-4-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gnf2vhv9Gk05aQGdPvQroaBx4EEbccau4" Subject: Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: quintela@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gnf2vhv9Gk05aQGdPvQroaBx4EEbccau4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2015 07:09 AM, zhanghailiang wrote: > The original 'status' is an open-coded 'str' type, convert it to use an= > enum type. > This conversion is backwards compatible, better documented and > more convenient for future extensibility. >=20 > We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION_STATUS_FAILED'. I argue that this change should be done in 1/4. > In addition, Fix a typo for qapi-schema.json: comppleted -> completed but this one can stay here. >=20 > Signed-off-by: zhanghailiang > --- > hmp.c | 7 ++++--- > migration/migration.c | 34 ++++++++++++---------------------- > qapi-schema.json | 34 +++++++++++++++++++++++++++++----- > 3 files changed, 45 insertions(+), 30 deletions(-) >=20 Otherwise, modulo Markus' review, it's looking better. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gnf2vhv9Gk05aQGdPvQroaBx4EEbccau4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU+dMeAAoJEKeha0olJ0NqL94H/0P/+Edo+13UbcgnXbUbecRY 1VDVGpVMUGLN8vYU5/rfSKOZThSrI1xZYFoW16umi7F20iN2du7xvkjCr66fb0Om p46l42U6NBRWFD19bYxcn8KvW8Fsq5dm8syRoa8RQIwt5jdkI7DCGX+ucW6wq2a2 iHrPWswCC+D+RD0B3zwUAt/DNeUyN3B9o1NRtKRfxfGRHooLM4i691eW6tx2zXZt KIVDntZGnr4NEgviGI6PsRIYTPjnvRAVl0ShZXsLvMSpibVw2vJZXyzI8uFkt9fn a51SyeYYyJZQfo1QJhUyx3UFqZogrYFZKwYkpi2jztqvQB5m2N7gRTF/FtIYqTY= =2riz -----END PGP SIGNATURE----- --gnf2vhv9Gk05aQGdPvQroaBx4EEbccau4--