From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Tomeu Vizoso
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Daniel Stone <daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [pinmux scripts PATCH] Update Nyan-Big pinmux from ChromeOS
Date: Fri, 06 Mar 2015 13:31:55 -0700 [thread overview]
Message-ID: <54FA0EBB.3080208@wwwdotorg.org> (raw)
In-Reply-To: <1425672435-19031-1-git-send-email-daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
On 03/06/2015 01:07 PM, Daniel Stone wrote:
> Update the pinmux, in particular USB and SD/MMC pin configuration, from
> downstream ChromeOS kernel. Fixes external USB falling off completely
> during heavy eMMC activity.
Simon (and Tomeu),
Can you comment on this change? If the data currently in
tegra-pinmux-scripts is wrong, where did it come from if not the
ChromeOS kernel?
> Signed-off-by: Daniel Stone <daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> configs/nyan-big.board | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/configs/nyan-big.board b/configs/nyan-big.board
> index 6ebe466..03d40d4 100644
> --- a/configs/nyan-big.board
> +++ b/configs/nyan-big.board
> @@ -94,7 +94,7 @@ pins = (
> ('pex_l1_clkreq_n_pdd6', 'rsvd2', None, 'down', True, False, False, False),
> ('pex_l1_rst_n_pdd5', 'rsvd2', None, 'down', True, False, False, False),
> ('pex_wake_n_pdd3', 'rsvd2', None, 'down', True, False, False, False),
> - ('usb_vbus_en2_pff1', 'rsvd2', None, 'down', True, False, False, False),
> + ('usb_vbus_en2_pff1', 'rsvd2', None, 'up', True, True, False, False),
> ('pff2', 'rsvd2', None, 'down', True, False, False, False),
> ('clk2_out_pw5', 'rsvd2', None, 'down', True, False, False, False),
> ('clk2_req_pcc5', 'rsvd2', None, 'down', True, False, False, False),
> @@ -105,16 +105,16 @@ pins = (
> ('sdmmc1_dat1_py6', 'sdmmc1', None, 'up', False, True, False, False),
> ('sdmmc1_dat2_py5', 'sdmmc1', None, 'up', False, True, False, False),
> ('sdmmc1_dat3_py4', 'sdmmc1', None, 'up', False, True, False, False),
> - ('sdmmc3_clk_pa6', 'sdmmc3', None, 'none', False, False, False, False),
> + ('sdmmc3_clk_pa6', 'sdmmc3', None, 'none', False, True, False, False),
> ('sdmmc3_cmd_pa7', 'sdmmc3', None, 'up', False, True, False, False),
> ('sdmmc3_dat0_pb7', 'sdmmc3', None, 'up', False, True, False, False),
> ('sdmmc3_dat1_pb6', 'sdmmc3', None, 'up', False, True, False, False),
> ('sdmmc3_dat2_pb5', 'sdmmc3', None, 'up', False, True, False, False),
> ('sdmmc3_dat3_pb4', 'sdmmc3', None, 'up', False, True, False, False),
> - ('sdmmc3_clk_lb_out_pee4', 'sdmmc3', None, 'none', False, False, False, False),
> + ('sdmmc3_clk_lb_out_pee4', 'sdmmc3', None, 'none', False, True, False, False),
> ('sdmmc3_clk_lb_in_pee5', 'sdmmc3', None, 'up', False, True, False, False),
> ('sdmmc4_clk_pcc4', 'sdmmc4', None, 'none', False, True, False, False),
> - ('sdmmc4_cmd_pt7', 'sdmmc4', None, 'none', False, True, False, False),
> + ('sdmmc4_cmd_pt7', 'sdmmc4', None, 'up', False, True, False, False),
> ('sdmmc4_dat0_paa0', 'sdmmc4', None, 'up', False, True, False, False),
> ('sdmmc4_dat1_paa1', 'sdmmc4', None, 'up', False, True, False, False),
> ('sdmmc4_dat2_paa2', 'sdmmc4', None, 'up', False, True, False, False),
> @@ -183,14 +183,14 @@ pins = (
> ('uart3_rxd_pw7', 'rsvd2', None, 'down', True, False, False, False),
> ('uart3_txd_pw6', 'rsvd2', None, 'down', True, False, False, False),
> ('owr', 'rsvd2', None, 'down', True, False, False, False),
> - ('hdmi_cec_pee3', 'cec', None, 'none', False, True, True, False),
> - ('hdmi_int_pn7', None, 'in', 'down', False, True, False, False),
> + ('hdmi_cec_pee3', 'cec', None, 'none', False, True, False, False),
> + ('hdmi_int_pn7', 'rsvd1', 'in', 'down', False, True, False, False),
> ('ddc_scl_pv4', 'i2c4', None, 'none', False, True, False, False),
> ('ddc_sda_pv5', 'i2c4', None, 'none', False, True, False, False),
> ('spdif_out_pk5', 'rsvd2', None, 'down', True, False, False, False),
> ('spdif_in_pk6', None, 'out0', 'down', False, False, False, False),
> - ('usb_vbus_en0_pn4', 'usb', None, 'none', False, True, True, False),
> - ('usb_vbus_en1_pn5', 'usb', None, 'none', False, True, True, False),
> + ('usb_vbus_en0_pn4', 'usb', None, 'up', False, True, False, False),
> + ('usb_vbus_en1_pn5', 'usb', None, 'up', False, True, False, False),
> ('dp_hpd_pff0', 'dp', None, 'none', False, True, False, False),
> )
>
>
next prev parent reply other threads:[~2015-03-06 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 20:07 [PATCH] Update Nyan-Big pinmux from ChromeOS Daniel Stone
[not found] ` <1425672435-19031-1-git-send-email-daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-03-06 20:31 ` Stephen Warren [this message]
[not found] ` <54FA0EBB.3080208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-03-06 20:42 ` [pinmux scripts PATCH] " Simon Glass
[not found] ` <CAPnjgZ0Uir9PZ1RWKCua0q0R6NMgGotqR7+jAkc_aJd1xTx4ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-06 20:46 ` Stephen Warren
2015-03-09 15:39 ` Daniel Stone
[not found] ` <1425915411.12254.0@mail.collabora.com>
[not found] ` <1425915411.12254.0-u1PCbA9B4pYthqhpMEQ9fNBPR1lH4CV8@public.gmane.org>
2015-03-09 16:23 ` Stephen Warren
2015-03-09 16:40 ` Daniel Stone
[not found] ` <loom.20150309T173610-946-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2015-03-10 16:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FA0EBB.3080208@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.