Re: [PATCH net-next 1/3] switchdev: fix stp update API to work with layered netdevices

[roopa <roopa@cumulusnetworks.com>]

On 3/6/15, 1:30 AM, Scott Feldman wrote:
> On Thu, Mar 5, 2015 at 8:04 PM,  <roopa@cumulusnetworks.com> wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> make it same as the netdev_switch_port_bridge_setlink/dellink
>> api (ie traverse lowerdevs to get to the switch port).
>>
>> removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because bridge ports
>> can be bonds and teams which might not implement this ndo.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> ---
>>   include/net/switchdev.h   |    7 +++++++
>>   net/switchdev/switchdev.c |   30 +++++++++++++++++++++++++++++-
>>   2 files changed, 36 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>> index cfcdac2..a93279b 100644
>> --- a/include/net/switchdev.h
>> +++ b/include/net/switchdev.h
>> @@ -51,6 +51,7 @@ int ndo_dflt_netdev_switch_port_bridge_dellink(struct net_device *dev,
>>                                                 struct nlmsghdr *nlh, u16 flags);
>>   int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *dev,
>>                                                 struct nlmsghdr *nlh, u16 flags);
>> +int ndo_dflt_netdev_switch_port_stp_update(struct net_device *dev, u8 state);
>>   #else
>>
>>   static inline int netdev_switch_parent_id_get(struct net_device *dev,
>> @@ -109,6 +110,12 @@ static inline int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *
>>          return 0;
>>   }
>>
>> +static inline int ndo_dflt_netdev_switch_port_stp_update(struct net_device *dev,
>> +                                                        u8 state)
>> +{
>> +       return 0;
> Shouldn't this be return -EOPNOTSUPP to be consistent with
> netdev_switch_port_stp_update() when CONFIG_NET_SWITCHDEV is not
> defined?
good point. I have made all the dflt op functions return 0 so far. It 
does not hurt.
But, to be consistent...yes i will change it to -EOPNOTSUPP.

Thanks scott.