From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbbCGRo2 (ORCPT ); Sat, 7 Mar 2015 12:44:28 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:36301 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbCGRo1 (ORCPT ); Sat, 7 Mar 2015 12:44:27 -0500 Message-ID: <54FB38F8.1080600@lwfinger.net> Date: Sat, 07 Mar 2015 11:44:24 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: 54FB3523.7060600@lwfinger.net CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock References: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> <54FB3523.7060600@lwfinger.net> <1425749756.11323.5.camel@gmail.com> In-Reply-To: <1425749756.11323.5.camel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2015 11:35 AM, Matteo Semenzato wrote: > Il giorno sab, 07/03/2015 alle 11.28 -0600, Larry Finger ha scritto: >> Have you actually tested this patch, or did you find this with some static checker? >> >> Larry > The double unlock was found using smatch. Are you really willing to test changes in locking based on a static checker? I would not be so quick. By the way, my reading of the documentation is that up releases the lock whereas down sets it. Thus, I think your patch introduces a bug rather than fix one. I agree that there is a mismatch, but I do not think your patch fixes anything. Until this is actually tested on running code, NACK. Larry