From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Basic A33 support including dram init available in my personal repo
Date: Sat, 07 Mar 2015 20:06:27 +0100 [thread overview]
Message-ID: <54FB4C33.6050008@redhat.com> (raw)
In-Reply-To: <54F43A7F.4020803@redhat.com>
Hi,
On 02-03-15 11:25, Hans de Goede wrote:
> Hi,
>
> On 01-03-15 19:42, Vishnu Patekar wrote:
>> Allwinner A33 tablets comes with the libdram binary, fortunately I've
>> found the libdram code at
>> https://github.com/realthunder/a33_bootloader/tree/master/basic_loader/bsp/bsp_for_a67.
>
> Ah, that is both good and bad...
>
>> I've integrated it with mainline u-boot, still lot to do to post it to upstream
>
> Integrated sounds as if you've copied pieces of code from the bsp code you've found
> into mainline u-boot. That is a big no no (this the bad part). AFAIK the bsp code
> does not come with a GPL license header, and Allwinner does not want to release
> these bits under the GPL for whatever reasons, a lot can be said about this, but
> in the end currently the bsp code is not GPL licensed, so we cannot use it / copy
> from it. There can be no discussion on this, when you're submitting this upstream
> you must not have any literal copied code in the patch you're sending upstream.
>
> You can use non copyrightable information from the bsp sources like register
> names and the initialization algorithm (IANAL), but you must 100% write your own
> code!
Ok, so something (to me) quite unexpected has happened and Allwinner has just
released what seems to be ALL there boot0 code under the GPL, it can found here:
https://github.com/allwinner-zh/bootloader/tree/master/basic_loader/boot0
https://github.com/allwinner-zh/bootloader/tree/master/basic_loader/bsp
Specifically interesting for the discussion at hand is:
https://github.com/allwinner-zh/bootloader/blob/master/basic_loader/bsp/bsp_for_a33/init_dram/mctl_hal.c
Which caries a GPL header now. This completely changes my story above, whatever
you have (or had, sorry) was fine. It should still be cleaned up a bit, but all
my worries about copy and pasting non GPL code are gone now.
Regards,
Hans
next prev parent reply other threads:[~2015-03-07 19:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 18:42 [U-Boot] Basic A33 support including dram init available in my personal repo Vishnu Patekar
2015-03-02 10:25 ` Hans de Goede
2015-03-02 11:51 ` Vishnu Patekar
2015-03-02 12:25 ` Hans de Goede
2015-03-04 12:33 ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
2015-03-04 14:06 ` Hans de Goede
2015-03-07 19:06 ` Hans de Goede [this message]
2015-03-08 0:03 ` Siarhei Siamashka
2015-03-09 8:39 ` Vishnu Patekar
2015-03-09 9:04 ` Chen-Yu Tsai
2015-03-09 9:05 ` Hans de Goede
2015-03-09 9:10 ` Vishnu Patekar
2015-03-09 14:52 ` Maxime Ripard
2015-04-06 9:16 ` [U-Boot] " Hans de Goede
2015-04-06 10:48 ` Vishnu Patekar
2015-04-06 13:31 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FB4C33.6050008@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.