From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id D3BCA105059A for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id CE54544D398 for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kPGjhPcsf1CH for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id AF75F44D391 for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J-yWcUVGtT0o for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra13.linbit.com (Postfix) with ESMTPS id 7FA8944D398 for ; Fri, 13 Mar 2015 00:08:11 +0100 (CET) Resent-Message-ID: <20150312230811.GO3961@soda.linbit> Message-ID: <54FB98F3.2050308@fb.com> Date: Sat, 7 Mar 2015 17:33:55 -0700 From: Jens Axboe MIME-Version: 1.0 To: David Rientjes , Lars Ellenberg References: In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, drbd-user@lists.linbit.com Subject: Re: [Drbd-dev] [patch 1/2] block, drbd: fix drbd_req_new() initialization List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/07/2015 05:24 PM, David Rientjes wrote: > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > initialize it to 0. You should add it to mempool instead, avoid having this issue show up for other folks as well. It'd be trivial to do. Normal ->alloc() should honor __GFP_ZERO, just do the same manually for removing an item from the internal pool. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751173AbbCHAeF (ORCPT ); Sat, 7 Mar 2015 19:34:05 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:57368 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbbCHAeC (ORCPT ); Sat, 7 Mar 2015 19:34:02 -0500 Message-ID: <54FB98F3.2050308@fb.com> Date: Sat, 7 Mar 2015 17:33:55 -0700 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Rientjes , Lars Ellenberg CC: , Subject: Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization References: In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-03-08_01:2015-03-06,2015-03-07,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=1.17239551400417e-13 kscore.compositescore=0 circleOfTrustscore=0 compositescore=0.985052395226116 suspectscore=2 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.985052395226116 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=0 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.985052395226116 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1503080004 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2015 05:24 PM, David Rientjes wrote: > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > initialize it to 0. You should add it to mempool instead, avoid having this issue show up for other folks as well. It'd be trivial to do. Normal ->alloc() should honor __GFP_ZERO, just do the same manually for removing an item from the internal pool. -- Jens Axboe